From owner-cvs-all@FreeBSD.ORG Tue Aug 1 08:52:48 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76AF216A4E0; Tue, 1 Aug 2006 08:52:48 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id E989E43D49; Tue, 1 Aug 2006 08:52:46 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5EEFD.dip.t-dialin.net [84.165.238.253]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.6/8.13.6) with ESMTP id k718dLQu024519; Tue, 1 Aug 2006 10:39:22 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k718qkTi043728; Tue, 1 Aug 2006 10:52:47 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Date: Tue, 1 Aug 2006 10:54:25 +0200 From: Alexander Leidinger To: infofarmer@FreeBSD.org Message-ID: <20060801105425.779a4b26@Magellan.Leidinger.net> In-Reply-To: References: <200607302234.k6UMYUuq018943@repoman.freebsd.org> <20060731121024.3d6478b4@Magellan.Leidinger.net> X-Mailer: Sylpheed-Claws 2.3.1 (GTK+ 2.8.20; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: cvs-ports@FreeBSD.org, sat@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.linux-rpm.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 08:52:48 -0000 Quoting "Andrew Pantyukhin" (Mon, 31 Jul 2006 19:38:33 +0400): > On 7/31/06, Alexander Leidinger wrote: > > Quoting Andrew Pantyukhin (Sun, 30 Jul 2006 22:34:30 +0000 (UTC)): > > > > > sat 2006-07-30 22:34:30 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > Mk bsd.linux-rpm.mk > > > Log: > > > - Only set default m_s_subdir if master_sites was undefined > > > > Would you please describe which problem this commit tries to solve > > (perhaps as a forced commit)? > > Fedora has a rather unique MSS scheme (related to its versioning) > and applying the scheme to another MS does not seem very > practical. In practice, a more relevant default value might be > attempted to be set after bsd.linux-rpm.mk. The default linux base is FC4, and most linux-infrastructure ports are from FC4 too. Those ports are the only ports which use this stuff ATM. So ATM it's very practical. > > I'm not sure if we have some ports which set MS but depend on the auto > > assigning of MSS, but I would not be surprised if we have such ports. > > Did you check for such ports? > > Sure. There are 29 USE_LINUX_RPM ports, only three set MS, > two of them don't need MSS at all and the third one would rather > MSS was not touched by linux-rpm.mk. Which port is the third one? > I'm sorry I committed this without prior discussion, but I tried to > make sure the change was not desctructive and as simple as it > gets. The mk is used by a lot of ports, so any bug may harm a lot of ports. I don't object if you want to join us at emulation@ (actually I would be very happy to see more contributors), but a review request for changes with a high impact ratio (in case of a bug) would be very nice next time. Bye, Alexander. -- Sometimes one should just look at things and think about things without doing things. -- Calvin http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137