From owner-p4-projects@FreeBSD.ORG Thu Jan 8 19:00:03 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 778A0106566B; Thu, 8 Jan 2009 19:00:03 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3193F1065672; Thu, 8 Jan 2009 19:00:03 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from websrv01.jr-hosting.nl (websrv01.jr-hosting.nl [78.47.69.233]) by mx1.freebsd.org (Postfix) with ESMTP id E135A8FC14; Thu, 8 Jan 2009 19:00:02 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from [195.64.94.120] (helo=[10.0.2.153]) by websrv01.jr-hosting.nl with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1LKzqm-000328-NL; Thu, 08 Jan 2009 19:43:24 +0100 Message-Id: <61E32407-BF64-47D0-89E9-EB0B9EB22B91@elvandar.org> From: Remko Lodder To: Hans Petter Selasky In-Reply-To: <200901081839.27124.hselasky@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Thu, 8 Jan 2009 19:43:19 +0100 References: <200901071009.n07A9jrs056953@repoman.freebsd.org> <20090108.102311.1541746851.imp@bsdimp.com> <200901081839.27124.hselasky@freebsd.org> X-Mailer: Apple Mail (2.930.3) Cc: perforce@freebsd.org, "M. Warner Losh" Subject: Re: PERFORCE change 155748 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2009 19:00:04 -0000 On Jan 8, 2009, at 6:39 PM, Hans Petter Selasky wrote: > On Thursday 08 January 2009, M. Warner Losh wrote: >> In message: <200901071009.n07A9jrs056953@repoman.freebsd.org> >> >> Hans Petter Selasky writes: >> : http://perforce.freebsd.org/chv.cgi?CH=155748 >> : >> : Change 155748 by hselasky@hselasky_laptop001 on 2009/01/07 10:09:35 >> : >> : >> : Umass module quirk from Alexander Best >> : to support Meizu Electronics MiniPlayer. >> : >> : Affected files ... >> : >> : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit >> : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 >> edit >> : .. //depot/projects/usb/src/sys/dev/usb2/include/ >> usb2_devtable.h#21 edit >> : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit >> : >> : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 >> : (text+ko) ==== ==== >> : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 >> : (text+ko) ==== >> >> Why are these generated files committed to the tree? We did a lot of >> work to make usbdevs generated files not need to be committed to the >> tree and this breaks that... >> >> Warner > > Because they are not automatically generated any more. > > --HPS Hmm, I liked the idea of only needing to do something marginally to add something. If files are no longer generated automatically and I need to do more, I'll look for other low hanging fruit. In short: can you restore automatic regenerating behaviour? -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News