Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Jul 2000 03:51:23 +0900
From:      FUJISHIMA Satsuki <k5@cheerful.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/20261: fix: audio/xmms
Message-ID:  <864s5agkb8.wl@cheerful.com>

next in thread | raw e-mail | index | archive | help

>Number:         20261
>Category:       ports
>Synopsis:       fix: audio/xmms linked against both libc and libc_r
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 28 12:00:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     FUJISHIMA Satsuki
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
N/A
>Environment:
>Description:

	Currently xmms is linked against both libc and libc_r due to lack
	of LIBTOOLFILES.

>How-To-Repeat:

/usr/ports/audio/xmms$ make
...
/usr/lib/libc.so.4: WARNING!  setkey(3) not present in the system!
/usr/lib/libc.so.4: warning: this program uses gets(), which is unsafe.
/usr/lib/libc.so.4: warning: mktemp() possibly used unsafely; consider using mkstemp()
/usr/lib/libc.so.4: WARNING!  des_setkey(3) not present in the system!
/usr/lib/libc.so.4: WARNING!  encrypt(3) not present in the system!
/usr/lib/libc.so.4: warning: tmpnam() possibly used unsafely; consider using mkstemp()
/usr/lib/libc.so.4: warning: this program uses f_prealloc(), which is stupid.
/usr/lib/libc.so.4: WARNING!  des_cipher(3) not present in the system!
...


>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/xmms/Makefile,v
retrieving revision 1.18
diff -u -w -B -b -r1.18 Makefile
--- Makefile	2000/07/13 20:20:21	1.18
+++ Makefile	2000/07/28 07:42:46
@@ -24,6 +24,7 @@
 
 USE_X_PREFIX=   yes
 USE_LIBTOOL=    yes
+LIBTOOLFILES=	configure libxmms/configure
 INSTALLS_SHLIB= yes
 
 .if !defined(WITHOUT_MIKMOD)

Comparing before and after this patch:

/usr/ports/audio/xmms$ diff -u log-before log-after
--- log-before	Fri Jul 28 15:48:14 2000
+++ log-after	Fri Jul 28 15:44:29 2000
@@ -298,8 +298,7 @@
 mv -f .libs/formatter.lo formatter.lo
 /bin/sh ./libtool --mode=link cc  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o libxmms.la -rpath /usr/X11R6/lib -export-dynamic -version-info 1:0:0 configfile.lo xmmsctrl.lo dirbrowser.lo util.lo  formatter.lo -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm 
 rm -fr .libs/libxmms.la .libs/libxmms.* .libs/libxmms.*
-cc -shared  configfile.lo xmmsctrl.lo dirbrowser.lo util.lo formatter.lo  -L/usr/local/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -lintl -lXext -lX11 -lm -lc  -Wl,-soname -Wl,libxmms.so.1 -o .libs/libxmms.so.1
-(cd .libs && rm -f libxmms.so && ln -s libxmms.so.1 libxmms.so)
+cc -shared  -Wl,--rpath -Wl,/usr/X11R6/lib  configfile.lo xmmsctrl.lo dirbrowser.lo util.lo formatter.lo  -L/usr/local/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm  -Wl,-soname -Wl,libxmms.so.1 -o .libs/libxmms.so.1
 (cd .libs && rm -f libxmms.so && ln -s libxmms.so.1 libxmms.so)
 ar cru .libs/libxmms.a  configfile.o xmmsctrl.o dirbrowser.o util.o formatter.o 
 ranlib .libs/libxmms.a
@@ -352,17 +351,9 @@
 cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -D_THREAD_SAFE -I/usr/local/include -I/usr/X11R6/include -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -DDATA_DIR=\"/usr/X11R6/share/xmms\" -DPLUGIN_DIR=\"/usr/X11R6/lib/xmms\" -DPLUGINSUBS=\"Output\",\"Input\",\"Effect\",\"General\",\"Visualization\" -DLOCALEDIR=\"/usr/X11R6/share/locale\" -DI386_ASSEM -I../intl  -I/usr/local/include  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -c urldecode.c
 /bin/sh ../libtool --mode=link cc  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o xmms -export-dynamic bmp.o skin.o util.o output.o fft.o input.o effect.o  general.o visualization.o dga.o fullscreen.o pluginenum.o playlist.o  controlsocket.o dock.o widget.o sbutton.o pbutton.o tbutton.o textbox.o  menurow.o hslider.o monostereo.o vis.o svis.o number.o playstatus.o  playlist_list.o playlist_slider.o playlist_popup.o eq_graph.o  eq_slider.o main.o skinwin.o prefswin.o playlistwin.o equalizer.o  hints.o about.o sm.o getopt.o getopt1.o urldecode.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -pthread -lSM -lICE -lXxf86dga -lXxf86vm  ../libxmms/libxmms.la 
 mkdir .libs
-cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/xmms bmp.o skin.o util.o output.o fft.o input.o effect.o general.o visualization.o dga.o fullscreen.o pluginenum.o playlist.o controlsocket.o dock.o widget.o sbutton.o pbutton.o tbutton.o textbox.o menurow.o hslider.o monostereo.o vis.o svis.o number.o playstatus.o playlist_list.o playlist_slider.o playlist_popup.o eq_graph.o eq_slider.o main.o skinwin.o prefswin.o playlistwin.o equalizer.o hints.o about.o sm.o getopt.o getopt1.o urldecode.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -pthread -lSM -lICE -lXxf86dga -lXxf86vm ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -lintl -lXext -lX11 -lm -Wl,--export-dynamic -Wl,--rpath -Wl,/usr/X11R6/lib
+cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/xmms bmp.o skin.o util.o output.o fft.o input.o effect.o general.o visualization.o dga.o fullscreen.o pluginenum.o playlist.o controlsocket.o dock.o widget.o sbutton.o pbutton.o tbutton.o textbox.o menurow.o hslider.o monostereo.o vis.o svis.o number.o playstatus.o playlist_list.o playlist_slider.o playlist_popup.o eq_graph.o eq_slider.o main.o skinwin.o prefswin.o playlistwin.o equalizer.o hints.o about.o sm.o getopt.o getopt1.o urldecode.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -pthread -lSM -lICE -lXxf86dga -lXxf86vm ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,--export-dynamic -Wl,--rpath -Wl,/usr/X11R6/lib
 skin.o: In function `_load_skin':
 skin.o(.text+0x12c2): warning: tempnam() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: WARNING!  setkey(3) not present in the system!
-/usr/lib/libc.so.4: warning: this program uses gets(), which is unsafe.
-/usr/lib/libc.so.4: warning: mktemp() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: WARNING!  des_setkey(3) not present in the system!
-/usr/lib/libc.so.4: WARNING!  encrypt(3) not present in the system!
-/usr/lib/libc.so.4: warning: tmpnam() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: warning: this program uses f_prealloc(), which is stupid.
-/usr/lib/libc.so.4: WARNING!  des_cipher(3) not present in the system!
 creating xmms
 Making all in Output
 Making all in OSS
@@ -664,31 +655,13 @@
 cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -D_THREAD_SAFE -I/usr/local/include -I/usr/X11R6/include -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -DDATA_DIR=\"/usr/X11R6/share/xmms\" -DPLUGIN_DIR=\"/usr/X11R6/lib/xmms\" -DPLUGINSUBS=\"Output\",\"Input\",\"Effect\",\"General\",\"Visualization\" -DLOCALEDIR=\"/usr/X11R6/share/locale\" -I../intl  -I/usr/local/include  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -c wmxmms.c
 /bin/sh ../libtool --mode=link cc  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o wmxmms  getopt.o getopt1.o wmxmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm ../libxmms/libxmms.la 
 mkdir .libs
-cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/wmxmms getopt.o getopt1.o wmxmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -lintl -lXext -lX11 -lm -Wl,--rpath -Wl,/usr/X11R6/lib
-/usr/lib/libc.so.4: WARNING!  setkey(3) not present in the system!
-/usr/lib/libc.so.4: warning: this program uses gets(), which is unsafe.
-/usr/lib/libc.so.4: warning: mktemp() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: WARNING!  des_setkey(3) not present in the system!
-/usr/lib/libc.so.4: WARNING!  encrypt(3) not present in the system!
-/usr/lib/libc.so.4: warning: tmpnam() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: warning: this program uses f_prealloc(), which is stupid.
-/usr/lib/libc.so.4: WARNING!  des_cipher(3) not present in the system!
-/usr/lib/libc.so.4: warning: tempnam() possibly used unsafely; consider using mkstemp()
+cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/wmxmms getopt.o getopt1.o wmxmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,--rpath -Wl,/usr/X11R6/lib
 creating wmxmms
 Making all in gnomexmms
 cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -D_THREAD_SAFE -I/usr/local/include -I/usr/X11R6/include -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -DDATA_DIR=\"/usr/X11R6/share/xmms\" -DPLUGIN_DIR=\"/usr/X11R6/lib/xmms\" -DPLUGINSUBS=\"Output\",\"Input\",\"Effect\",\"General\",\"Visualization\" -DLOCALEDIR=\"/usr/X11R6/share/locale\" -I/usr/X11R6/include -DNEED_GNOMESUPPORT_H -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include/gtk12 -I../intl  -I/usr/local/include  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -c gnomexmms.c
 /bin/sh ../libtool --mode=link cc  -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o gnomexmms  gnomexmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,-E -L/usr/X11R6/lib -L/usr/local/lib -Wl,-E -lgnorba -lORBitCosNaming -lORBit -lIIOP -lORBitutil -lXpm -ljpeg -lgnomeui -lart_lgpl -lgdk_imlib -ltiff -lungif -lpng -lz -lSM -lICE -lgtk12 -lgdk12 -lgmodule12 -lXext -lX11 -lgnome -lgnomesupport -lintl -lesd -laudiofile -lm -lglib12 -lpanel_applet ../libxmms/libxmms.la 
 mkdir .libs
-cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/gnomexmms gnomexmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,-E -L/usr/X11R6/lib -L/usr/local/lib -Wl,-E -lgnorba -lORBitCosNaming -lORBit -lIIOP -lORBitutil -lXpm -ljpeg -lgnomeui -lart_lgpl -lgdk_imlib -ltiff -lungif -lpng -lz -lSM -lICE -lgtk12 -lgdk12 -lgmodule12 -lXext -lX11 -lgnome -lgnomesupport -lintl -lesd -laudiofile -lm -lglib12 -lpanel_applet ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -lintl -lXext -lX11 -lm -Wl,--rpath -Wl,/usr/X11R6/lib
-/usr/lib/libc.so.4: WARNING!  setkey(3) not present in the system!
-/usr/lib/libc.so.4: warning: this program uses gets(), which is unsafe.
-/usr/lib/libc.so.4: warning: mktemp() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: WARNING!  des_setkey(3) not present in the system!
-/usr/lib/libc.so.4: WARNING!  encrypt(3) not present in the system!
-/usr/lib/libc.so.4: warning: tmpnam() possibly used unsafely; consider using mkstemp()
-/usr/lib/libc.so.4: warning: this program uses f_prealloc(), which is stupid.
-/usr/lib/libc.so.4: WARNING!  des_cipher(3) not present in the system!
-/usr/lib/libc.so.4: warning: tempnam() possibly used unsafely; consider using mkstemp()
+cc -O -pipe -march=i686 -mfancy-math-387 -fomit-frame-pointer -finline-functions -ffast-math -L/usr/local/lib -o .libs/gnomexmms gnomexmms.o -L/usr/X11R6/lib -L/usr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -Wl,-E -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,-E -L/usr/X11R6/lib -L/usr/local/lib -Wl,-E -lgnorba -lORBitCosNaming -lORBit -lIIOP -lORBitutil -lXpm -ljpeg -lgnomeui -lart_lgpl -lgdk_imlib -ltiff -lungif -lpng -lz -lSM -lICE -lgtk12 -lgdk12 -lgmodule12 -lXext -lX11 -lgnome -lgnomesupport -lintl -lesd -laudiofile -lm -lglib12 -lpanel_applet ../libxmms/.libs/libxmms.so -lgtk12 -lgdk12 -lgmodule12 -lgthread12 -lglib12 -pthread -lintl -lXext -lX11 -lm -Wl,--rpath -Wl,/usr/X11R6/lib
 creating gnomexmms
 Making all in intl
 Making all in po

Bogus warings have gone. Looks good.

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864s5agkb8.wl>