From owner-svn-src-all@FreeBSD.ORG Tue Mar 24 02:47:15 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 36A98F39 for ; Tue, 24 Mar 2015 02:47:15 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F183C7B0 for ; Tue, 24 Mar 2015 02:47:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t2O2lEZ1097782 for ; Tue, 24 Mar 2015 02:47:14 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t2O2lEDL097779 for svn-src-all@freebsd.org; Tue, 24 Mar 2015 02:47:14 GMT (envelope-from bdrewery) Received: (qmail 5717 invoked from network); 23 Mar 2015 21:47:11 -0500 Received: from unknown (HELO blah) (freebsd@shatow.net@10.10.1.90) by sweb.xzibition.com with ESMTPA; 23 Mar 2015 21:47:11 -0500 Message-ID: <5510D02F.2080007@FreeBSD.org> Date: Mon, 23 Mar 2015 21:47:11 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rui Paulo Subject: Re: svn commit: r280410 - head/sys/kern References: <201503240217.t2O2HHgU052651@svn.freebsd.org> <5510CB0E.5010208@FreeBSD.org> <29715C14-0AC2-43A2-A718-E89AC3C57AC0@me.com> In-Reply-To: <29715C14-0AC2-43A2-A718-E89AC3C57AC0@me.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 02:47:15 -0000 On 3/23/15 9:35 PM, Rui Paulo wrote: > On Mar 23, 2015, at 19:25, Bryan Drewery wrote: >> >> On 3/23/15 9:17 PM, Rui Paulo wrote: >>> Author: rpaulo >>> Date: Tue Mar 24 02:17:17 2015 >>> New Revision: 280410 >>> URL: https://svnweb.freebsd.org/changeset/base/280410 >>> >>> Log: >>> Disable coredump_devctl because it could lead to leaking paths to >>> jails. >>> >>> Modified: >>> head/sys/kern/kern_sig.c >>> >>> Modified: head/sys/kern/kern_sig.c >>> ============================================================================== >>> --- head/sys/kern/kern_sig.c Tue Mar 24 01:32:46 2015 (r280409) >>> +++ head/sys/kern/kern_sig.c Tue Mar 24 02:17:17 2015 (r280410) >>> @@ -180,7 +180,7 @@ static int set_core_nodump_flag = 0; >>> SYSCTL_INT(_kern, OID_AUTO, nodump_coredump, CTLFLAG_RW, &set_core_nodump_flag, >>> 0, "Enable setting the NODUMP flag on coredump files"); >>> >>> -static int coredump_devctl = 1; >>> +static int coredump_devctl = 0; >>> SYSCTL_INT(_kern, OID_AUTO, coredump_devctl, CTLFLAG_RW, &coredump_devctl, >>> 0, "Generate a devctl notification when processes coredump"); >>> >>> >> >> If there is a security concern about this feature I think more needs to be done than just flipping the default. It could easily be forgotten about and make a release. > > Sure, but to be honest there are already sysctls that make your system insecure and we've been making releases with them for many years. > > -- > Rui Paulo > I just think the known issue should be documented at the least. -- Regards, Bryan Drewery