From owner-freebsd-current  Fri Aug 17  5:39: 1 2001
Delivered-To: freebsd-current@freebsd.org
Received: from wolf.istc.kiev.ua (wolf.istc.kiev.ua [193.193.221.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 492A137B406; Fri, 17 Aug 2001 05:38:52 -0700 (PDT)
	(envelope-from max@vega.com)
Received: from vega.vega.com (root@[62.149.3.53])
	by wolf.istc.kiev.ua ( . . / . . ) with ESMTP id PAA31986;
	Fri, 17 Aug 2001 15:27:43 +0300
Received: (from max@localhost)
	by vega.vega.com (8.11.4/8.11.3) id f7HCWRb19147;
	Fri, 17 Aug 2001 15:32:27 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
From: Maxim Sobolev <sobomax@FreeBSD.ORG>
Message-Id: <200108171232.f7HCWRb19147@vega.vega.com>
Subject: Re: 4-STABLE-->5-CURRENT upgrade path is b0rken in libform [patch]
To: ru@FreeBSD.ORG (Ruslan Ermilov)
Date: Fri, 17 Aug 2001 15:31:53 +0300 (EEST)
Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), current@FreeBSD.ORG
In-Reply-To: <20010817140912.B88339@sunbay.com> from "Ruslan Ermilov" at Aug 17, 2001 02:09:12 PM
X-Mailer: ELM [version 2.5 PL5]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> 
> On Fri, Aug 17, 2001 at 01:21:59PM +0300, Maxim Sobolev wrote:
> > Hi,
> > 
> > Currently 4-STABLE --> 5-CURRENT upgrade path is broken in libform
> > because it uses older curses.h header from the host system, which
> > misses some macros necessary. Attached patch is expected to fix the
> > problem, please review it and let me know if it is OK to commit it.
> > 
> Are you sure?
> 
> 1.  We currently run `buildworld' with -nostdinc, so /usr/include
>     (unless explicitly specified by CFLAGS) headers aren't used.
> 
> 2.  `make includes' is executed first, before `make libraries' in
>     `buildworld', and the former installs the correct curses.h
>     into /usr/obj/usr/src/i386/usr/include.
> 
> 3.  I can't reproduce your problem on my dual 4.4-PREPELEASE and
>     5.0-CURRENT box.
> 
> I can only imagine this scenario if you try to execure `make all'
> from src/lib/libform manually.


Hmm, strange, I can't reproduce this problem in the "clean room" either.
Perhaps there was some local configuration problem. Sorry for the false
alarm. :(

-Maxim

> 
> > Index: Makefile
> > ===================================================================
> > RCS file: /home/ncvs/src/lib/libform/Makefile,v
> > retrieving revision 1.6
> > diff -d -u -r1.6 Makefile
> > --- Makefile	2001/03/27 17:27:01	1.6
> > +++ Makefile	2001/08/17 10:16:24
> > @@ -21,8 +21,9 @@
> >  INCS=	${NCURSES}/form/form.h
> >  
> >  CLEANFILES+=	ncurses_def.h
> > -CFLAGS+= -I. -I${.CURDIR}/../libncurses -I${NCURSES}/form -I${NCURSES}/menu \
> > -	-I${NCURSES}/include -Wall -DNDEBUG -DHAVE_CONFIG_H
> > +CFLAGS+= -I. -I${.CURDIR}/../libncurses -I${.OBJDIR}/../libncurses \
> > +	-I${NCURSES}/form -I${NCURSES}/menu -I${NCURSES}/include \
> > +	-Wall -DNDEBUG -DHAVE_CONFIG_H
> >  
> >  ncurses_def.h:	MKncurses_def.sh ncurses_defs
> >  	AWK=${AWK} sh ${NCURSES}/include/MKncurses_def.sh \
> 
> 
> Cheers,
> -- 
> Ruslan Ermilov		Oracle Developer/DBA,
> ru@sunbay.com		Sunbay Software AG,
> ru@FreeBSD.org		FreeBSD committer,
> +380.652.512.251	Simferopol, Ukraine
> 
> http://www.FreeBSD.org	The Power To Serve
> http://www.oracle.com	Enabling The Information Age
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message