From nobody Mon Aug 4 23:54:54 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bwths56w4z63hJm for ; Mon, 04 Aug 2025 23:55:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bwths2Gnwz3d0c for ; Mon, 04 Aug 2025 23:55:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3b792b0b829so3733011f8f.3 for ; Mon, 04 Aug 2025 16:55:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754351707; x=1754956507; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DxKsCYlsS8gyYMstNfPYB7fWfIMIVv76B10jKjgGaDI=; b=GlCPi8H+mwwwfMdi8ezX8mdsJA7zr4sAs38lxbrWcF+k5j00QOu/9jWjF6VwL4UjiL cjjnjtlrOeLuEjMT3ftPaNUZpodc0D5eVa0TYRrzS/oWp3WnCsAtnmNeh/5Q5FBsiaS3 iz5r3CuYmrzolF8n1C0Lwx+Evv3iJMVEzhswu47EOZHa2UZ/6gfoPOgzL0hkA39hx1nn +asa/Ra7tl0L9RdIGu2koIDgriyunLPr5Ucw2S+oMGl9s2KEkVVDPoRhzko6gyLK5GoN N68W7H+xUN39jeb9bynfLnJCNaUHA7lI7ppte6j4dfv0N5EgE/AbJyU+hECrg2dskiGs f+dw== X-Forwarded-Encrypted: i=1; AJvYcCXnZmQ5aptKtXY8m49WCYm7WLCS1OvXyOssWNcOJF9xF3gXWEHOCl/33gjpE6aeG8Zs6Pci9kUEcz4LI2HWw8gwcOWD@freebsd.org X-Gm-Message-State: AOJu0YwAVRhi4oBvM6mlvQtQZDkupjzOvYu5Xyd1qAMS6lAwayHmb+cF 8ArSB4NHoecc9tWtRWySR1UVtBBVSX3VuNVCr0Difz1LwrYqYmK8hPm7TbfdByW7dIQ= X-Gm-Gg: ASbGnctsGSWYu9CHi8uw0vF79jjsRWzEd5pak3hHSFG0X3ozTJd1daIwJ1TGd/hZAXp ebV/bLoUVIz5rvbCeL2m+MSr4FR8K7J/6rqqqe2XlnCdt4CVdCzwuzbVd79k6cO1QCCVYGBT1gL MNYnmepg7j8Xa+uZcmr4nKRnVls4aniMe4/oLn5Oxwo0XY1G9ILtaJibsDxiAoGsf1bHPK6LQ4l VIkEdfm/0OxUB+7RMPlg8tkF0yHaPuk3IueeORnGXghPh3PMAY7V9AvweWt+XtWdRka9/DFx+Ou O+Ce2MSlFXipsL11ZjJPA0SOxT52R5XTONkzZK3u9dc9A435pjhLoUve1pzfsWkdkT56qVBB37E J9IiJt54ZSXc1AHi8YWZUuGrnUfUNTIi57c8r4Wl80cC0BXmKahZ82y4VVxvERmokogdqKd4= X-Google-Smtp-Source: AGHT+IHZRfcc6l5s7NmaUSxPar7IE+uwQPqa9f2gwcAnCcluHZzWOFNkibzNvMPxNsYPVSKdyP6xJg== X-Received: by 2002:a5d:5849:0:b0:3b7:7563:9fde with SMTP id ffacd0b85a97d-3b8d946c00bmr8796210f8f.2.1754351706823; Mon, 04 Aug 2025 16:55:06 -0700 (PDT) Received: from smtpclient.apple (global-184-99.n-1.net.cam.ac.uk. [131.111.184.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b8e9464f46sm2911366f8f.19.2025.08.04.16.55.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Aug 2025 16:55:05 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: 51affb7e9716 - main - nfscl: Fix GetACL so that it does not want a reply cached From: Jessica Clarke In-Reply-To: <202508042339.574NdNmf032977@gitrepo.freebsd.org> Date: Tue, 5 Aug 2025 00:54:54 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202508042339.574NdNmf032977@gitrepo.freebsd.org> To: Rick Macklem X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Rspamd-Queue-Id: 4bwths2Gnwz3d0c X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 5 Aug 2025, at 00:39, Rick Macklem wrote: > The branch main has been updated by rmacklem: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D51affb7e97161e260f6d99cb0904daf7= cc9f51a7 >=20 > commit 51affb7e97161e260f6d99cb0904daf7cc9f51a7 > Author: Rick Macklem > AuthorDate: 2025-08-04 23:36:28 +0000 > Commit: Rick Macklem > CommitDate: 2025-08-04 23:36:28 +0000 >=20 > nfscl: Fix GetACL so that it does not want a reply cached >=20 > Without this patch, an NFSv4.1/4.2 GetACL RPC requests that > the session cache the reply. In some cases, the reply may > be too large to cache, resulting in a NFS4ERR_X > error from the server. >=20 > Since a GetACL is idempotent, disable reply caching for it, > by setting that it can generate a large reply. > Tested against a Linux server with a large ACL on a file. >=20 > MFC after: 2 weeks > --- > sys/fs/nfs/nfs_commonsubs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c > index 4ffc4ce5c29f..67e33193ecec 100644 > --- a/sys/fs/nfs/nfs_commonsubs.c > +++ b/sys/fs/nfs/nfs_commonsubs.c > @@ -218,7 +218,7 @@ NFSD_VNET_DEFINE_STATIC(u_char *, nfsrv_dnsname) =3D= NULL; > */ > static int nfs_bigreply[NFSV42_NPROCS] =3D { 0, 0, 0, 1, 0, 1, 1, 0, = 0, 0, 0, > 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, = 0, 0, 0, > - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, = 0, 0, 0, > + 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, = 0, 0, 0, > 1, 0, 0, 1, 0, 0, 0, 0, 0, 0 }; This would be much more readable and maintainable as a C99 designated initialiser. Jess > /* local functions */