From owner-svn-src-head@FreeBSD.ORG Wed Dec 18 18:56:51 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F1E3B409 for ; Wed, 18 Dec 2013 18:56:50 +0000 (UTC) Received: from nm6.bullet.mail.bf1.yahoo.com (nm6.bullet.mail.bf1.yahoo.com [98.139.212.165]) by mx1.freebsd.org (Postfix) with SMTP id 90ED818DD for ; Wed, 18 Dec 2013 18:56:50 +0000 (UTC) Received: from [98.139.212.151] by nm6.bullet.mail.bf1.yahoo.com with NNFMP; 18 Dec 2013 18:51:11 -0000 Received: from [98.139.211.203] by tm8.bullet.mail.bf1.yahoo.com with NNFMP; 18 Dec 2013 18:51:10 -0000 Received: from [127.0.0.1] by smtp212.mail.bf1.yahoo.com with NNFMP; 18 Dec 2013 18:51:10 -0000 X-Yahoo-Newman-Id: 964958.65046.bm@smtp212.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Im98BsAVM1l4k1Fv4aZZcI7Uyu1V3v0mgRzHi58CxzGEZtC 9PTOiy6g3U4_4NdiFFxIIP1di88VHpjtQFEIrWBn5ncnCvYgT28Pcp4XSUJV TcBtSzp9IABJw16I6SAkKglcJ5KJKCeb_hY6BIhRwMUEm4X1qVrBD1dgJS1a nAVc92WmSq_tZ_32gOIyMMJKHs4rNGCKpmy2cWznFyJMYRvCME1BJXho2zMq AV91JCKzyEURKoL_TN.SycCWV.DweTJvu9a_.FM02mDY6bLLQ6yoLUMSinn8 PJ98ps.rx.EDmKYXHriZbHcdOHpgKnB5YDwlo48g8e3zwgAwIGKQgjViqYkP Rq5EkfISMTcM7eInQVLuTT33Si6PrpeRs10ijQRyAqrFoL5zvq2aRgoxMkO3 wWbuxNm8uDje15DBWJs2dk8TFUs4AqG0LKuF29zuapEQZEthzSDJ32L9HtRe lqlqH2lMyr9VvSevFDvk2CdxRLLC6W9NOxhhVTLCcbPiaB3mOGKGRSDXzSpm MRex4zgFRtiAWkd1jD4E3bzC0kgGVoC8JENyyhRREBa8aPwMcWKJnHtkF6ni c5_IhMnmkMiM0aCJGQ6tBhgYeCudGITuFT7MXOPkRNo1hdyhKnQEmyjE50_n nwmL1_wPlnMTAt8DKO14Yqs.Mdlz0mKQe8BLNHlz6JRPLpF8szxRZDojrwIp H4ZO3ZPoXvgE2T00iSmFkS4F.r6hV9_QZ90D2gpdnItjg X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with plain [63.250.193.228]) by smtp212.mail.bf1.yahoo.com with SMTP; 18 Dec 2013 10:51:05 -0800 PST Message-ID: <52B1EE95.3030104@FreeBSD.org> Date: Wed, 18 Dec 2013 13:51:01 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r259555 - in head/contrib: gcc gcc/doc gcclibs/libcpp gcclibs/libcpp/include References: <201312181453.rBIEranx037463@svn.freebsd.org> <20131218154253.GA18580@FreeBSD.org> In-Reply-To: <20131218154253.GA18580@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2013 18:56:51 -0000 On 18.12.2013 10:42, Alexey Dokuchaev wrote: > On Wed, Dec 18, 2013 at 02:53:36PM +0000, Pedro F. Giffuni wrote: >> New Revision: 259555 >> URL: http://svnweb.freebsd.org/changeset/base/259555 >> >> Log: >> gcc: add Apple compatible -Wnewline-eof >> >> GCC 4.2 and previous have always warned about >> "No newline at end of file". >> >> Upstream GCC removed the warning completely but >> Apple made it an optional warning. Adopt it for >> compatibility with older GCC and clang. > As someone who hates files that lack newline at EOF, I could never understand > why they (upstream) removed this warning. > > ./danfe The main discussion took place here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331 FWIW, I like the warning too. Cheers, Pedro.