Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Aug 2005 21:51:17 -0700
From:      Nate Lawson <nate@root.org>
To:        acpi@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_cpu.c
Message-ID:  <4313E5C5.5060005@root.org>
In-Reply-To: <20050830044536.C0AB416A4C6@hub.freebsd.org>
References:  <20050830044536.C0AB416A4C6@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote:
> njl         2005-08-30 04:45:32 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_cpu.c 
>   Log:
>   Eliminate cpufreq levels for two cases that are less than optimal:
>   
>   1. Walk the absolute list in reverse to prefer duplicated levels that have
>   a lower absolute setting, i.e. 800 Mhz/50% is better than 1600 Mhz/25% even
>   though both have the same actual frequency.  This also removes the need to
>   check for already-modified levels since by definition, those will be added
>   later in the sorted list.
>   
>   2. Compare the absolute settings for derived levels and don't use the new
>   level if it's higher.  For example, a level of 800 Mhz/75% is preferable to
>   1600 Mhz/25% even though the latter has a lower total frequency.
>   
>   This work is based on a patch from the submitter but reworked by myself.
>   
>   Submitted by:   Tijl Coosemans (tijl/ulyssis.org)
>   
>   Revision  Changes    Path
>   1.20      +48 -47    src/sys/kern/kern_cpu.c

If this commit gives you problems, please set debug.cpufreq.verbose=1 
and send me the output along with sysctl dev.cpu.  It should reduce the 
levels the same as Tijl's patch.  I took a very slightly different 
implementation approach but the code is mostly his.  Thanks!

-- 
Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4313E5C5.5060005>