Date: Thu, 17 Sep 2009 16:05:41 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Henrik Brix Andersen <brix@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/bitlbee/files bitlbee.in Message-ID: <20090917190540.GA20217@bluepex.com> In-Reply-To: <4AB28654.4090706@FreeBSD.org> References: <200909131035.n8DAZND8097060@repoman.freebsd.org> <4AB28654.4090706@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu, Sep 17, 2009 at 11:56:20AM -0700, Doug Barton wrote:
> Henrik Brix Andersen wrote:
> > brix 2009-09-13 10:35:23 UTC
> >
> > FreeBSD ports repository
> >
> > Modified files:
> > irc/bitlbee/files bitlbee.in
> > Log:
> > - Use -u ${user} option to bitlbee instead of su in rc.d script
> >
> > PR: ports/138268 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=138268
> > Submitted by: garga
> >
> > Revision Changes Path
> > 1.4 +2 -2 ports/irc/bitlbee/files/bitlbee.in
> >
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/bitlbee/files/bitlbee.in.diff?&r1=1.3&r2=1.4&f=h
>
> With this change the script can be further simplified as attached.
> LOGIN is needed instead of DAEMON since it's running as a specific
> user. We also generally prefer that ports stuff uses LOGIN unless
> something earlier is needed.
>
>
> hth,
>
> Doug
>
> --
>
> This .signature sanitized for your protection
>
> --- /usr/ports/irc/bitlbee/files/bitlbee.in 2009-09-14 13:04:11.000000000 -0700
> +++ bitlbee.in 2009-09-17 11:53:39.000000000 -0700
> @@ -3,7 +3,7 @@
> # $FreeBSD: ports/irc/bitlbee/files/bitlbee.in,v 1.4 2009/09/13 10:35:23 brix Exp $
> #
> # PROVIDE: bitlbee
> -# REQUIRE: DAEMON
> +# REQUIRE: LOGIN
> # KEYWORD: shutdown
>
> # Add the following lines to /etc/rc.conf to enable bitlbee:
> @@ -23,12 +23,6 @@
>
> required_files="${bitlbee_config}"
> command="%%PREFIX%%/sbin/bitlbee"
> -start_cmd="bitlbee_start"
> -
> -bitlbee_start()
> -{
> - echo "Starting ${name}."
> - ${command} -D -u ${bitlbee_user} -c ${bitlbee_config} ${bitlbee_flags}
> -}
> +command_args="-D -u ${bitlbee_user} -c ${bitlbee_config}"
>
> run_rc_command "$1"
Indeed, seems really better
- --
Renato Botelho <garga @ FreeBSD.org>
<garga @ freebsdbrasil.com.br>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
Song Title of the Week:
"They're putting dimes in the hole in my head to see the change
in me."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (FreeBSD)
iEYEARECAAYFAkqyiIQACgkQ6CRbiSJE7alfQgCfSskqtlU26TnLebTOj/G4KSY6
2KoAnj0fghYbC9Y+3UtawQuRGnebY4UG
=dy/R
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090917190540.GA20217>