Date: Sun, 16 Nov 2014 12:33:45 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Olli Hauer <ohauer@FreeBSD.org>, svn-ports-all@freebsd.org, Alfred Perlstein <alfred@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r372622 - in head/editors/vim: . files Message-ID: <20141116113345.GG45145@ivaldir.etoilebsd.net> In-Reply-To: <F61D76AA4CF82F5E4FC8BFAF@atuin.in.mat.cc> References: <201411160232.sAG2WJ4Z084790@svn.freebsd.org> <54687C89.20206@gmx.de> <F61D76AA4CF82F5E4FC8BFAF@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--2E/hm+v6kSLEYT3h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 16, 2014 at 12:24:04PM +0100, Mathieu Arnold wrote:
> +--On 16 novembre 2014 11:29:29 +0100 olli hauer <ohauer@gmx.de> wrote:
> |> +.if ${PORT_OPTIONS:MDEFAULT_VIMRC}
> |> + ${INSTALL_DATA} ${FILESDIR}/vimrc
> |> ${STAGEDIR}${DEFAULT_VIMRC_LOCATION}/vimrc +.endif
> |> =20
> | ...
> |=20
> | Thanks for installing a default vimrc file, but isn't it safer to insta=
ll
> | the vimrc file with the @sample macro to protect users having already a
> | own vimrc file installed?
>=20
> Yes, please, install a .sample file and use @sample in the plist, you're
> going to overwrite people's existing vimrc.
>=20
I first asked alfred to do such before the commit.
But when looking at how vim handles vimrc this is a fallback location hence=
this
vimrc is only loaded only if there is no user supplied vimrc
':version' will show you:
system vimrc file: "$VIM/vimrc"
user vimrc file: "$HOME/.vimrc"
2nd user vimrc file: "~/.vim/vimrc"
user exrc file: "$HOME/.exrc"
fall-back for $VIM: "/usr/local/share/vim"
So now I'm thinking there is no need for a @sample ...vimrc.sample given th=
is
vimrc is doing to be installed in the fall-back location.
But I do not think adding yet another option is worth, it should probably a=
lways
be installed.
Regards,
Bapt
--2E/hm+v6kSLEYT3h
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlRoi5kACgkQ8kTtMUmk6EzPDgCcDrz4D4e2zxLprve5UOW0CJGi
5wQAoIr9QmAvQ5W9V3LZFkUDjNfeMGhF
=uBrv
-----END PGP SIGNATURE-----
--2E/hm+v6kSLEYT3h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141116113345.GG45145>