From owner-freebsd-hackers Sun Jul 15 11:25:14 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from smtp1.xs4all.nl (smtp1.xs4all.nl [194.109.127.131]) by hub.freebsd.org (Postfix) with ESMTP id 3D59937B408; Sun, 15 Jul 2001 11:25:09 -0700 (PDT) (envelope-from wkb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp1.xs4all.nl (8.9.3/8.9.3) with ESMTP id UAA17078; Sun, 15 Jul 2001 20:25:06 +0200 (CEST) Received: (from wkb@localhost) by freebie.xs4all.nl (8.11.4/8.11.4) id f6FIP5B03080; Sun, 15 Jul 2001 20:25:05 +0200 (CEST) (envelope-from wkb) Date: Sun, 15 Jul 2001 20:25:05 +0200 From: Wilko Bulte To: "David O'Brien" Cc: Jens Schweikhardt , hackers@FreeBSD.ORG Subject: Re: Whitespace at end of line Message-ID: <20010715202505.A94801@freebie.xs4all.nl> References: <20010715155941.C1165@schweikhardt.net> <20010715111956.A71874@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010715111956.A71874@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sun, Jul 15, 2001 at 11:19:57AM -0700 X-OS: FreeBSD 4.3-STABLE X-PGP: finger wilko@freebsd.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jul 15, 2001 at 11:19:57AM -0700, David O'Brien wrote: > On Sun, Jul 15, 2001 at 03:59:41PM +0200, Jens Schweikhardt wrote: > > Dima and /me recently started weeding out white space at end of line for > > the man pages. I want to widen the weeding to include as much files as > > possible under /usr/src. > > Please do not do this to the .[ch] files. It makes diffs to stable harder. > > You may not know this, but in the early history of the "new" CVS tree > (ie. /home/ncvs vs. /home/cvs) with the 4.4BSD Lite code someone did this > (including pulling files off the vendor branch). In the end this has > really irritated *many* a FreeBSD developer. Please leave such cleanup to > when people are in the files cleaning up other style nits so we don't > have 1 million commits, each taking care of just one point of style(9). > > And as you mentioned in your email, there are cases where you could > change the semantics. If one is doing a few files at a time, they can > catch the semantic changes. When doing it in-mass using a script, you > will miss at least one. Maybe I'm just plain dim today (I will add a beer to rectify this situation at first convenience..) but what is so bad about some trailing whitespace that a massive commit-a-thlon is called for? just wondering, Wilko -- | / o / / _ Arnhem, The Netherlands email: wilko@FreeBSD.org |/|/ / / /( (_) Bulte "Youth is not a time in life, it is a state of mind" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message