From owner-svn-src-head@freebsd.org Mon May 23 23:53:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72230B47EB2; Mon, 23 May 2016 23:53:44 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ig0-f193.google.com (mail-ig0-f193.google.com [209.85.213.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 429331CC8; Mon, 23 May 2016 23:53:43 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ig0-f193.google.com with SMTP id c3so379792igl.3; Mon, 23 May 2016 16:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=XMiH53Ea3uvy8C2dw1mMB38Hyx4iMOXuZGhCVaSdLAI=; b=X5YLfPUZaMvDMyOirFRsFzDQXFvnQNefLzIvUW43YZ2ZExVKq6YXH3qxXepD/lLCyg 0kA4ihI7YKzvOcLwt7AoLa+pL+GHrSlUsD0Ae6i++KiTu0wp7tgfLZJ9LhNq/yDEtilm 9+RGRI/KfRGJrJ08gOcF86qZjSQt/HhCEffO87/H0PxfEhNDD0CC4NfDeZMjRutVUzn5 2QMoLyct8FgO8KeoUr9Ckt82gblIhe+k6qABmYxIEZEzcLLE/k58V+GgKd74VUqqucmP 5CZt0e+x1NyFohv7uj43FeXKfP+bDntf/6SSgzHa2oSl9GP5CxAlMyEDX2juovT354dc 0chw== X-Gm-Message-State: ALyK8tJCDs0PRfkuP0Uq4oYR0TW27h2Lvj7+kvFmUXLQZp28/cVOaPlFFCGRu1LPc0ejiA== X-Received: by 10.50.228.47 with SMTP id sf15mr3680499igc.63.1464046938128; Mon, 23 May 2016 16:42:18 -0700 (PDT) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com. [209.85.213.179]) by smtp.gmail.com with ESMTPSA id wh5sm4529189igb.19.2016.05.23.16.42.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 May 2016 16:42:17 -0700 (PDT) Received: by mail-ig0-f179.google.com with SMTP id bi2so43036295igb.0; Mon, 23 May 2016 16:42:17 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.50.4.101 with SMTP id j5mr15337130igj.8.1464046937141; Mon, 23 May 2016 16:42:17 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.36.205.70 with HTTP; Mon, 23 May 2016 16:42:17 -0700 (PDT) In-Reply-To: References: <201605042234.u44MYBMX054443@repo.freebsd.org> <2368543.Vvp613SNcD@ralph.baldwin.cx> <684f4a82-f48c-b2bb-6a72-5c1dfea11a39@pix.net> <8074ef26-cb70-2397-b71e-b897a1270d22@FreeBSD.org> Date: Mon, 23 May 2016 16:42:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r299090 - in head: etc/mtree include lib/libbluetooth sbin/hastd share/man/man3 sys/dev/xen/blkback sys/kern sys/net sys/sys tests/sys tests/sys/sys usr.sbin/bluetooth/hccontrol From: Conrad Meyer To: Alan Somers Cc: Bryan Drewery , Kurt Lidl , John Baldwin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 23:53:44 -0000 On Mon, May 23, 2016 at 4:34 PM, Alan Somers wrote: > On Mon, May 23, 2016 at 5:13 PM, Bryan Drewery wrote: >> >> On 5/23/16 1:30 PM, Alan Somers wrote: >> > UPDATING is updated as of r300539. Any objection to merging this to >> > stable/10? >> >> If any port uses it then yes. Binaries are built from 10.1 and expected >> to work on 10.1, 10.2, 10.3, 10.4, etc. > > > Most ports that use bitstring should work. The only ports that won't are > ports that either store bitstrings on disk or transmit them across a network > without an explicit serialization step. A few other weird cases would break > too, like building a port on 10.3, updating sys/bitstring.h, then rebuilding > some object files but not others. Is there any way to figure out what ports > might be using this header? OpenHub code search didn't turn up anything. It seems to me like this is exactly the sort of ABI breakage the stable/* branches promise not to make. On the other hand, it seems to me like the majority of the benefit of this patch could be gained without breaking ABI. (Optimistically iterate longs rather than bytes if the pointer's alignment is suitable.) Best, Conrad