From owner-svn-ports-head@freebsd.org Mon Dec 24 08:40:43 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83CEA133A717; Mon, 24 Dec 2018 08:40:43 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 269B975975; Mon, 24 Dec 2018 08:40:43 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8FD3D114F6; Mon, 24 Dec 2018 08:40:42 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Mon, 24 Dec 2018 09:40:37 +0100 From: Mathieu Arnold To: Eugene Grosbein Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r488248 - in head/net-im: . pidgin-icyque Message-ID: <20181224084037.gzfxjggzfr6dfmk4@atuin.in.mat.cc> References: <201812240035.wBO0ZVAo071499@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yobmfkq4qatyq4la" Content-Disposition: inline In-Reply-To: <201812240035.wBO0ZVAo071499@repo.freebsd.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 269B975975 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.76 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.76)[-0.762,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2018 08:40:43 -0000 --yobmfkq4qatyq4la Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 24, 2018 at 12:35:31AM +0000, Eugene Grosbein wrote: > +BUILD_DEPENDS=3D pidgin:net-im/pidgin > +RUN_DEPENDS=3D pidgin:net-im/pidgin > +LIB_DEPENDS=3D libjson-glib-1.0.so:devel/json-glib \ > + libpurple.so:net-im/libpurple The order is BUILD/LIB/RUN. > +PLIST_FILES=3D lib/purple-2/libicyque.so Wrong place in the Makefile. See https://www.freebsd.org/doc/en/books/port= ers-handbook/porting-order.html > +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME} Not needed. > +USE_GNOME=3D glib20 > +USE_LDCONFIG=3D yes Wrong place in the Makefile (though removing the WRKSRC above will fix it.) > +This is a Libpurple plugin for ICQ/WIM protocol. This is way too short, pkg-descr must be at least a couple of lines long. --=20 Mathieu Arnold --yobmfkq4qatyq4la Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlwgm4RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkioHA/+O+qDut1io2VQncIh/4s/sXXBMPOgYVuW6xXSpC1Ww2bUu24jezgjyvRP ksLk7QYpb14iL9xEvKuSSNbAUM0O5R3OvOdNxi1P2gXKV6dX235bG3hhZjgnDUOw U9CLTbaCGGtBho6ry9wLOaVF5PNVcF4qKNMEYdut203BxN8IHYQGSFaKR6Q/yTq0 iz3WVIIHIXPjratHRY3K+0rSO7EZ9KhZQN2Rp0OnzZrbEVdEU9TZduPx/2uJihxT FCFbEPY0uVdLlSjdyUvgQTIKaQuorpBHdZC35VJvSx5xLtXvXj/ISxy77D/FsvOF kDjS9nsKWshNMJ/yNAVZUwxn4RGL4g5jvn+zYWeqQ9RnfLN1I35d2NaeFH75sfPc 4ChLwUf7uFwdXFKnycYtEJ1YfU1GTLS5WMBqB3fa2OZomBREz94l2JHXz4dPiHKG CaB5QDdjzW3PozlGR5UrQ4zgguq04OWRg+TGPRQth5aONzM9SgZDZlhcBrOQGMRb Nu4z4F8UotQLMgBxdaVLey1vSyrQ8qRUC2mWRnqT9fk6FZSV/uugNKXGwy3HhXa8 JowcIwL/B7RUtAD4aSnKCEblgZzF84IodWVkG/V+llAeax5JRL4l+HZXFTbBUjtX WJ4VcMZ+2UZs09NzXzQic+e7WITAXef9kh94rDm7+tnIo0wgJJo= =fX9M -----END PGP SIGNATURE----- --yobmfkq4qatyq4la--