From owner-cvs-all Mon Apr 8 21:18: 1 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 8D9F837B400; Mon, 8 Apr 2002 21:17:55 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g394Hsi94770; Mon, 8 Apr 2002 22:17:54 -0600 (MDT) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g394Hrc26634; Mon, 8 Apr 2002 22:17:53 -0600 (MDT) (envelope-from imp@village.org) Date: Mon, 08 Apr 2002 22:17:51 -0600 (MDT) Message-Id: <20020408.221751.81468575.imp@village.org> To: kris@obsecurity.org Cc: jhb@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ioccom.h From: "M. Warner Losh" In-Reply-To: <20020408.221017.117026133.imp@village.org> References: <20020408210151.B18407@xor.obsecurity.org> <20020408.221017.117026133.imp@village.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020408210151.B18407@xor.obsecurity.org> Kris Kennaway writes: : It was broken by r1.11 of ioccom.h as stated, AFAICT. gcc apparently : treats ioctl() and (ioctl)() as different prototypes. Actually, I don't think you are right. I just tried: int ioctl(int, unsigned long, ...); int (ioctl)(int, unsigned long, ...); and gcc didn't complain at all, even with -Wall I'll bet money that 1.10 actually broke things since they were done so close together. 1.10 change things from int ioctl __P((int, unsigned long, ...)); to int ioctl(int, unsigned long, ...); Can someone send me the ACTUAL code that this breaks? Every time I've asked on IRC I haven't gotten an answer that I can use to track down the real problem. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message