From owner-freebsd-stable@FreeBSD.ORG Fri Sep 10 12:00:27 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D76721065794 for ; Fri, 10 Sep 2010 12:00:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id A497C8FC33 for ; Fri, 10 Sep 2010 12:00:27 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0F9AC46BA7; Fri, 10 Sep 2010 08:00:27 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 107E98A04F; Fri, 10 Sep 2010 08:00:26 -0400 (EDT) From: John Baldwin To: freebsd-stable@freebsd.org Date: Fri, 10 Sep 2010 07:57:49 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <20100909150012.GA27370@lordcow.org> <4c89d653.UyUz1Sv9zPckJnig%perryh@pluto.rain.com> In-Reply-To: <4c89d653.UyUz1Sv9zPckJnig%perryh@pluto.rain.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009100757.49777.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 10 Sep 2010 08:00:26 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: bsd@lordcow.org, perryh@pluto.rain.com Subject: Re: MSIX failure X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 12:00:27 -0000 On Friday, September 10, 2010 2:55:15 am perryh@pluto.rain.com wrote: > Gareth de Vaux wrote: > > > On Thu 2010-09-09 (16:54), Kurt Jaeger wrote: > > > -c asks for pci device capabilities, which are read in > > > > > > /usr/src/usr.sbin/pciconf/pciconf.c:177 with O_RDWR > > > > Ah. I'll have to schedule a reboot then .. > > or hack on pciconf.c to not request more permission than it needs. > It is arguably a bug to open O_RDWR when only examining things. You have to have RDWR permission to issue the ioctl to read config registers which pciconf does when examining capabilities. -- John Baldwin