From owner-freebsd-gecko@FreeBSD.ORG Sun Nov 29 15:40:32 2009 Return-Path: Delivered-To: gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8890C106566C for ; Sun, 29 Nov 2009 15:40:32 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from smtp-vbr19.xs4all.nl (smtp-vbr19.xs4all.nl [194.109.24.39]) by mx1.freebsd.org (Postfix) with ESMTP id 1C1918FC17 for ; Sun, 29 Nov 2009 15:40:31 +0000 (UTC) Received: from [192.168.1.65] (kazerne.demon.nl [212.238.222.22]) by smtp-vbr19.xs4all.nl (8.13.8/8.13.8) with ESMTP id nATFND1G002044; Sun, 29 Nov 2009 16:23:13 +0100 (CET) (envelope-from kwm@rainbow-runner.nl) From: Koop Mast To: gecko@freebsd.org In-Reply-To: References: Content-Type: text/plain; charset="us-ascii" Date: Sun, 29 Nov 2009 16:26:06 +0100 Message-ID: <1259508366.1774.9.camel@headache.rainbow-runner.nl> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: by XS4ALL Virus Scanner Cc: gnome , barbara Subject: Re: graphics/librsvg2: build fail using WITH_MOZILLA_PLUGIN X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2009 15:40:32 -0000 On Sun, 2009-11-29 at 16:10 +0100, barbara wrote: > Trying to install librsvg2-2.26.0_2, I've got an error using WITH_MOZILLA_PLUGIN. Without that option it builds as expected. I CC'd the gecko team. They are doing a gecko rework. Can you take a look at this? It seems you broke librsvg2 mozilla plugin. -Koop > ---------------------------------------------------------------- > Making all in moz-plugin > gmake[2]: Entering directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0/moz-plugin' > /bin/sh /usr/ports/graphics/librsvg2/work/gnome-libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c -o moz-plugin.lo moz-plugin.c > gnome-libtool: compile: cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c moz-plugin.c -fPIC -DPIC -o .libs/moz-plugin.o > gnome-libtool: compile: cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c moz-plugin.c -o moz-plugin.o >/dev/null 2>&1 > mv -f .deps/moz-plugin.Tpo .deps/moz-plugin.Plo > /bin/sh /usr/ports/graphics/librsvg2/work/gnome-libtool --tag=CC --mode=link cc -O2 -pipe -fno-strict-aliasing -march=athlon-mp -module -avoid-version -L/usr/local/lib -o libmozsvgdec.la -rpath moz-plugin.lo -pthread -L/usr/local/lib -lgthread-2.0 -lglib-2.0 > gmake[2]: Leaving directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0/moz-plugin' > gmake[1]: Leaving directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0' > *** Error code 1 > > Stop in /usr/ports/graphics/librsvg2. > *** Error code 1 > > Stop in /usr/ports/graphics/librsvg2. > ---------------------------------------------------------------- > > It seems that the path after "-rpath" is missing. > Looking at the differences between Makefile.in.bak and Makefile.in in work/librsvg-2.26.0/moz-plugin, I think the the problem is the removal of the inclusion of Makefile.webplugins, because ${WEBPLUGINS_DIR} would be "" in post-patch phase. > > So this could be the patch: > ---------------------------------------------------------------- > --- Makefile.orig 2009-11-28 21:05:44.000000000 +0100 > +++ Makefile 2009-11-29 15:30:47.000000000 +0100 > @@ -49,6 +49,7 @@ > USE_GECKO= libxul seamonkey > USE_WEBPLUGINS= gecko19 > WEBPLUGINS_FILES=libmozsvgdec.so > +.include "${PORTSDIR}/www/firefox/Makefile.webplugins" > CONFIGURE_ENV+= MOZILLA_CONFIG=no > CONFIGURE_ARGS+=--enable-mozilla-plugin=yes > ---------------------------------------------------------------- > > > > Thanks > Barbara