From nobody Wed Oct 1 09:38:51 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8y372vmz69GRX; Wed, 01 Oct 2025 09:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8y35ZFsz3GyF; Wed, 01 Oct 2025 09:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xB3qnmAyGc8r7zQL5IuoxFPFLvl2ke5hE67s/7Aw9fk=; b=F4qARksuvQxqR7WRWml3HGkcrKQwgZll8VLgipilFVcCrNyufT/zz1HeuFQj2sHMn6aBYT gLGYHQId+Vhbu9if0s1bas1UMponYgpvcDCI1+mn+B0RqACMGvrLp4f5QFT9H0kgCjcqat 0TxaalBIkH/PS6d7RHRf66icFVAiVasSmnDGynDiNCVMZlR69a41EDXqbVyap14Ix+kcA1 jEUWpyiiP169kCMGhThb79VN5+HWOV9gffyH4w3GYGy9HXBXsO9/7hTKhffjf5uLIri9YH PifOcBGDElY911H1De2KQ/zTduaqcuzv2+Rzrlg2ZDmyYy6GmEok2B1IuWSsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xB3qnmAyGc8r7zQL5IuoxFPFLvl2ke5hE67s/7Aw9fk=; b=VDcvpFUnqhHqrJWjWj+kh+6BOxy/4XAmxf23sUAKYYJ/+a59FZ8yE3r7M4nuxASCbbBT2q Iw+tIFMRtGvQHoQaRYLH8KZnYZREWRPBEN3vxPkp5IvkIBrXLqf21ougy8uRXdEfWULt0D rJq/0wC1sD6MN3Fbf4vwDFISJjXP590j1pnQmyHYvR5Tp+5+yWLYu/IgNNQyg2zyOxV1HY lXpFm4W9Kr8q/w3uvkQRZkIRR2qnFV3ocb8Q9yDRJNUEVUlGNO90xSTGpOy+rypuK2zEkq LqjE6HFaZQhxWAx+D8Cc4TXxQ26MLQ6FGRkk5t6lYsl5xXN0F+frMFTzkcrmYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311531; a=rsa-sha256; cv=none; b=rBzWU5mcZ8T88vyNuHz1MWZYW+H41SEV5oCp+JeiSAqIQetJ1aJ6nFIQ0jBsdTw6A2oSbp UFYy04tNG57nfzhSoVfEVQE35piSO1LQayTOhKDDrTqQoa32s4yrNESO7h2oCiieRMi8G0 hwhvq09fOUmFvMb2JtCd6a7waIcaaU7JNFINiBjfbyiXA08o/swsCukOqvFPv97504RK8O JoDSDSw+sXZ19xNBP9FFiFh5rZZXN5x9YfceFK7nAGUQwSJnusXnYNuxgBgVpjGgxOwA0f WtPFpX7qNljbbiA0cvng9BynNImXIRph0ukCfZ5+bkkOqrZr1/XZPZ5JbNHnHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8y352ttz2JG; Wed, 01 Oct 2025 09:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919cpUc016523; Wed, 1 Oct 2025 09:38:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919cpuX016519; Wed, 1 Oct 2025 09:38:51 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:51 GMT Message-Id: <202510010938.5919cpuX016519@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: b6ad8caa24c2 - stable/14 - ng_tty: copy to the correct mbuf List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b6ad8caa24c2c6e7e1c8a844c2fd283a2fcfef3e Auto-Submitted: auto-generated The branch stable/14 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=b6ad8caa24c2c6e7e1c8a844c2fd283a2fcfef3e commit b6ad8caa24c2c6e7e1c8a844c2fd283a2fcfef3e Author: Ahmad Khalifa AuthorDate: 2025-09-25 16:54:28 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 08:35:01 +0000 ng_tty: copy to the correct mbuf memcpy should copy to the current mbuf, otherwise we're copying to the first mbuf in the chain over and over. Reported by: kevans Reviewed by: glebius MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52713 (cherry picked from commit e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0) --- sys/netgraph/ng_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index c7d8a1b64eac..0e3230a66f66 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -427,7 +427,7 @@ ngt_rint_bypass(struct tty *tp, const void *buf, size_t len) for (mb = m; mb != NULL; mb = mb->m_next) { length = min(M_TRAILINGSPACE(mb), len - total); - memcpy(mtod(m, char *), (const char *)buf + total, length); + memcpy(mtod(mb, char *), (const char *)buf + total, length); mb->m_len = length; total += length; m->m_pkthdr.len += length;