From owner-freebsd-stable@freebsd.org Wed May 9 16:54:11 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA0C6FC53F8 for ; Wed, 9 May 2018 16:54:10 +0000 (UTC) (envelope-from trond@fagskolen.gjovik.no) Received: from smtp.fagskolen.gjovik.no (smtp.fagskolen.gjovik.no [IPv6:2001:700:1100:1:200:ff:fe00:b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.fagskolen.gjovik.no", Issuer "Fagskolen i Gj??vik" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 60EC971A68 for ; Wed, 9 May 2018 16:54:10 +0000 (UTC) (envelope-from trond@fagskolen.gjovik.no) Received: from mail.fig.ol.no (localhost [127.0.0.1]) by mail.fig.ol.no (8.15.2/8.15.2) with ESMTPS id w49Gs69r039927 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 9 May 2018 18:54:06 +0200 (CEST) (envelope-from trond@fagskolen.gjovik.no) Received: from localhost (trond@localhost) by mail.fig.ol.no (8.15.2/8.15.2/Submit) with ESMTP id w49Gs6XZ039924 for ; Wed, 9 May 2018 18:54:06 +0200 (CEST) (envelope-from trond@fagskolen.gjovik.no) X-Authentication-Warning: mail.fig.ol.no: trond owned process doing -bs Date: Wed, 9 May 2018 18:54:06 +0200 (CEST) From: =?ISO-8859-1?Q?Trond_Endrest=F8l?= Sender: Trond.Endrestol@fagskolen.gjovik.no To: FreeBSD stable Subject: Re: pdeathsig_helper and .debug/pdeathsig_helper.debug placed in /mnt when DESTDIR=/mnt In-Reply-To: Message-ID: References: <20180509135046.GZ6887@kib.kiev.ua> User-Agent: Alpine 2.21.999 (BSF 260 2018-02-26) Organization: Fagskolen Innlandet OpenPGP: url=http://fig.ol.no/~trond/trond.key MIME-Version: 1.0 X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.fig.ol.no Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 16:54:11 -0000 On Wed, 9 May 2018 18:44+0200, Trond Endrestøl wrote: > On Wed, 9 May 2018 16:50+0300, Konstantin Belousov wrote: > > > On Wed, May 09, 2018 at 02:49:34PM +0200, Trond Endrest?l wrote: > > > I noticed two new entries in / after running make installworld today > > > using amd64 stable/11 r333390: > > > > > > # LANG=en_US.UTF-8 ls -lT /pdeathsig_helper /.debug/pdeathsig_helper.debug > > > -r--r--r-- 1 root wheel 7528 May 9 12:06:58 2018 /.debug/pdeathsig_helper.debug > > > -r-xr-xr-x 1 root wheel 8576 May 9 12:06:58 2018 /pdeathsig_helper > > > > > > I'm sure these belong in /usr/tests/sys/kern. This must have happened > > > in r333162 or shortly after. > > > > > > See PR 228018, of which I hijacked. > > > > Can you try this ? > > > > Index: tests/sys/kern/Makefile > > =================================================================== > > --- tests/sys/kern/Makefile (revision 333400) > > +++ tests/sys/kern/Makefile (working copy) > > @@ -4,6 +4,7 @@ > > .PATH: ${SRCTOP}/sys/kern > > > > TESTSDIR= ${TESTSBASE}/sys/kern > > +BINDIR= ${TESTDIR} > > > > ATF_TESTS_C+= kern_copyin > > ATF_TESTS_C+= kern_descrip_test > > I was not so lucky: > > ===> tests/sys/geom/class/uzip (install) > --- realinstall_subdir_tests/sys/kern --- > --- _proginstall --- > install -s -o root -g wheel -m 555 pdeathsig_helper /mnt/pdeathsig_helper > install -d /mnt/.debug/ > install -o root -g wheel -m 444 pdeathsig_helper.debug /mnt/.debug/pdeathsig_helper.debug > --- kern_copyin.install --- > (cd /usr/src/tests/sys/kern && DEPENDFILE=.depend.kern_copyin NO_SUBDIR=1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PROGS=t PROG=kern_copyin install) > --- realinstall_subdir_tests/sys/geom --- > --- _etalonINS --- > install -o root -g wheel -m 444 /usr/src/tests/sys/geom/class/uzip/etalon/etalon.txt /mnt/usr/tests/sys/geom/class/uzip/etalon/ > --- _SCRIPTSINS_1_test --- > install -o root -g wheel -m 555 1_test /mnt/usr/tests/sys/geom/class/uzip/1_test > --- _testsFILESINS_Kyuafile --- > install -o root -g wheel -m 444 Kyuafile /mnt/usr/tests/sys/geom/class/uzip/Kyuafile > --- _testsFILESINS --- > install -o root -g wheel -m 444 /usr/src/tests/sys/geom/class/uzip/conf.sh 1.img.uzip.uue /mnt/usr/tests/sys/geom/class/uzip/ > --- _testsFILESINS --- > install -o root -g wheel -m 444 /usr/src/tests/sys/geom/class/geom_subr.sh /mnt/usr/tests/sys/geom/class/ > --- realinstall_subdir_tests/sys/kern --- > --- _proginstall --- > --- realinstall_subdir_tests/sys/geom --- > --- _testsFILESINS_Kyuafile --- > --- realinstall_subdir_tests/sys/kern --- > install -s -o root -g wheel -m 555 kern_copyin /mnt /usr/tests/sys/kern/kern_copyin > --- realinstall_subdir_tests/sys/geom --- > install -o root -g wheel -m 444 Kyuafile > /mnt/usr/tests/sys/geom/class/Kyuafile > --- realinstall_subdir_tests/sys/kern --- > install: target `/usr/tests/sys/kern/kern_copyin' is not a directory > usage: install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner] > [-M log] [-D dest] [-h hash] [-T tags] > [-B suffix] [-l linkflags] [-N dbdir] > file1 file2 > install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner] > [-M log] [-D dest] [-h hash] [-T tags] > [-B suffix] [-l linkflags] [-N dbdir] > file1 ... fileN directory > install -dU [-vU] [-g group] [-m mode] [-N dbdir] [-o owner] > [-M log] [-D dest] [-h hash] [-T tags] > directory ... > *** [_proginstall] Error code 64 > > make[7]: stopped in /usr/src/tests/sys/kern > 1 error If I revert the changes to tests/sys/kern/Makefile, and try installworld installkernel again, I get: --- maninstall --- install -o root -g wheel -m 444 mailstats.8.gz /mnt/usr/share/man/man8/ --- realinstall_subdir_tests --- sh: cannot create Kyuafile.tmp: Read-only file system sh: cannot create Kyuafile.tmp: Read-only file system *** [Kyuafile] Error code 2 make[6]: stopped in /usr/src/tests/sys/kern 1 error Both /usr/src and /usr/obj are read-only NFSv3 exports. I should probably wipe the object tree before proceeding. -- Trond. From owner-freebsd-stable@freebsd.org Wed May 9 17:39:42 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72586FC6306 for ; Wed, 9 May 2018 17:39:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C75AC7CA1A for ; Wed, 9 May 2018 17:39:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w49HdLT4052917 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 9 May 2018 20:39:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w49HdLT4052917 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w49HdLFs052916; Wed, 9 May 2018 20:39:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 9 May 2018 20:39:21 +0300 From: Konstantin Belousov To: Trond Endrest?l Cc: FreeBSD stable Subject: Re: pdeathsig_helper and .debug/pdeathsig_helper.debug placed in /mnt when DESTDIR=/mnt Message-ID: <20180509173921.GB6887@kib.kiev.ua> References: <20180509135046.GZ6887@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 17:39:42 -0000 On Wed, May 09, 2018 at 06:44:09PM +0200, Trond Endrest?l wrote: > On Wed, 9 May 2018 16:50+0300, Konstantin Belousov wrote: > > > On Wed, May 09, 2018 at 02:49:34PM +0200, Trond Endrest?l wrote: > > > I noticed two new entries in / after running make installworld today > > > using amd64 stable/11 r333390: > > > > > > # LANG=en_US.UTF-8 ls -lT /pdeathsig_helper /.debug/pdeathsig_helper.debug > > > -r--r--r-- 1 root wheel 7528 May 9 12:06:58 2018 /.debug/pdeathsig_helper.debug > > > -r-xr-xr-x 1 root wheel 8576 May 9 12:06:58 2018 /pdeathsig_helper > > > > > > I'm sure these belong in /usr/tests/sys/kern. This must have happened > > > in r333162 or shortly after. > > > > > > See PR 228018, of which I hijacked. > > > > Can you try this ? > > > > Index: tests/sys/kern/Makefile > > =================================================================== > > --- tests/sys/kern/Makefile (revision 333400) > > +++ tests/sys/kern/Makefile (working copy) > > @@ -4,6 +4,7 @@ > > .PATH: ${SRCTOP}/sys/kern > > > > TESTSDIR= ${TESTSBASE}/sys/kern > > +BINDIR= ${TESTDIR} There is a type, it should be TESTSDIR. Index: tests/sys/kern/Makefile =================================================================== --- tests/sys/kern/Makefile (revision 333400) +++ tests/sys/kern/Makefile (working copy) @@ -4,6 +4,7 @@ .PATH: ${SRCTOP}/sys/kern TESTSDIR= ${TESTSBASE}/sys/kern +BINDIR= ${TESTSDIR} ATF_TESTS_C+= kern_copyin ATF_TESTS_C+= kern_descrip_test