From owner-freebsd-alpha@FreeBSD.ORG  Sat May 24 13:26:52 2003
Return-Path: <owner-freebsd-alpha@FreeBSD.ORG>
Delivered-To: freebsd-alpha@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D40EB37B401; Sat, 24 May 2003 13:26:52 -0700 (PDT)
Received: from canning.wemm.org (canning.wemm.org [192.203.228.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8149043F3F; Sat, 24 May 2003 13:26:52 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by canning.wemm.org (Postfix) with ESMTP
	id 68A9F2A7EA; Sat, 24 May 2003 13:26:52 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: Luigi Rizzo <luigi@freebsd.org>
In-Reply-To: <20030519004914.B46011@xorpc.icir.org> 
Date: Sat, 24 May 2003 13:26:52 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20030524202652.68A9F2A7EA@canning.wemm.org>
cc: freebsd-alpha@freebsd.org
Subject: Re: [FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64 
X-BeenThere: freebsd-alpha@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the Alpha <freebsd-alpha.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-alpha>
List-Post: <mailto:freebsd-alpha@freebsd.org>
List-Help: <mailto:freebsd-alpha-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 May 2003 20:26:53 -0000

Luigi Rizzo wrote:

>      if (cmd->opcode == O_LOG)
>  	cmd += F_LEN(cmd);
> +#ifdef I386
>      fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr;
> +#else
> +    bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs));
> +#endif
>  

This is not a 'reviewed-by:', but these should be #ifdef __i386__
rather than #ifdef I386.

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5