From owner-svn-src-head@freebsd.org Thu Oct 13 07:21:47 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBB74C0F5AE for ; Thu, 13 Oct 2016 07:21:47 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-qt0-f178.google.com (mail-qt0-f178.google.com [209.85.216.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9FAAB3D1 for ; Thu, 13 Oct 2016 07:21:47 +0000 (UTC) (envelope-from julio@meroh.net) Received: by mail-qt0-f178.google.com with SMTP id f6so34647018qtd.2 for ; Thu, 13 Oct 2016 00:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meroh.net; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gzUAQOFOnkwVkWCkbjrJvbtja6F89WMimYPVqEobAZU=; b=BZr2WxGYHzO5e44WCDPFrRzFphjb+Ju3sJcFFHrm1gi4UMCz6yN9QRk+OBt9muARvi 8C70CHZLp+l6F5t0L27VlBm7gLFgmE037qghexQmYlTMafdx3teFNzuNmPR+XrHXr8o/ y2a6G28Lsewn5taVo7i6dzG0HQo0Is4ZGnc1dyAZeRMqOADb4ID6SMkseLf+YqfeI3bO iM1xrNpEjUEmAhrSHdpGGFm8ZWY51unZKdfmJCdt7T4j21gLhpjod81nDcUTRk0XTuwz jbxwhH9Xdp7g97zWapZ4IA7JOa8sFyQK0tu8lQBTiqaJTNiOvjuB441y0oFci8bDw5ZO iFUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gzUAQOFOnkwVkWCkbjrJvbtja6F89WMimYPVqEobAZU=; b=Qq3/YNzA5J/cDVxpu/ee3/EZm0q2nXh/mi3pvFYUiXBHiALXIlIDUqNKBUzFgeYdXp WiGCMDIgKdr+i9tJ0mJ22k/VhQ+gud5C5z0uwBY9+bwstgZvoh8pSePTVhKoPalbi8Td T6SOaRb/2IfAi5khUuhAKFlLmpIL3j1JzVwBaWvTZsxwC0PxPZNDvyBtUT4CdNtBr5w3 B6Rlj5h/WAj3wpd9q9e/QS0FtEXbjxclv6wyIEgb8vdligW6W93TM/w+f+vGOQgdCKhr JhPW7h4PRJqwnsgIGAe65AoEtL+ujvj0RD5oL7QYVT13aueRLekF2s3MMhBcjG4/iSxu 8Pvg== X-Gm-Message-State: AA6/9RkTtjsCNHvfnquRoqdOg07D94sxJsRZd89TF4KrAUe2pc9nRBOnI2FD0RGSTrjGOEOguNcqSX0a6MHtQQ== X-Received: by 10.200.53.54 with SMTP id y51mr5284482qtb.132.1476343246155; Thu, 13 Oct 2016 00:20:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.56.93 with HTTP; Thu, 13 Oct 2016 00:20:25 -0700 (PDT) X-Originating-IP: [172.26.42.46] In-Reply-To: <201610130702.u9D72sgd007580@repo.freebsd.org> References: <201610130702.u9D72sgd007580@repo.freebsd.org> From: Julio Merino Date: Thu, 13 Oct 2016 03:20:25 -0400 Message-ID: Subject: Re: svn commit: r307190 - head/contrib/netbsd-tests/fs/tmpfs To: Ngie Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 07:21:47 -0000 On Thu, Oct 13, 2016 at 3:02 AM, Ngie Cooper wrote: > Author: ngie > Date: Thu Oct 13 07:02:54 2016 > New Revision: 307190 > URL: https://svnweb.freebsd.org/changeset/base/307190 > > Log: > Skip :uchg on FreeBSD > > Unfortunately removing files with uchg set always succeeds with root on > FreeBSD. Unfortunately running the test as an unprivileged user isn't > doable > because mounting tmpfs requires root > > PR: 212861 > Sponsored by: Dell EMC Isilon > > Modified: > head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > > Modified: head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > ============================================================ > ================== > --- head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 > 06:56:23 2016 (r307189) > +++ head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 > 07:02:54 2016 (r307190) > @@ -53,6 +53,10 @@ uchg_head() { > atf_set "require.user" "root" > } > uchg_body() { > + # Begin FreeBSD > + atf_skip "this fails on FreeBSD with root - bug 212861" > + # End FreeBSD > This is a bad way of disabling a test due to a known bug because, when the bug is resolved, the test won't notice. You should be using the "expected failures" functionality if possible, and based on the change description, I think you can do this here easily. Try: atf_expect_fail "FreeBSD bug 213861 blah blah" right before the line that triggers the test failure. -- Julio Merino -- http://julio.meroh.net/