From owner-svn-src-all@freebsd.org Tue Sep 20 04:03:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA7E9BDF619 for ; Tue, 20 Sep 2016 04:03:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BCDDCED7 for ; Tue, 20 Sep 2016 04:03:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22b.google.com with SMTP id r192so87486545ita.0 for ; Mon, 19 Sep 2016 21:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RcKIj9/yjdtNTZk08Yt26jaU9oVCeuEBh05f7kP/j/A=; b=iL7PtNbnOjN5C4ZWUYVEmsi/WGY3/ymo5x+ykymxA9nU4zjJ/sOpDmYLs7rh/vXZm0 Ojqi47wHAA5wIWIfWHK03QLxE2K2PgsP0TmaiBputYEwdrKeKhlbg/ZbUhkyZzsRTnUE gLZYYMrsg6Xrw+7hXxZJVCCPLWlh+a6wfhjq9Bz1cr97qROqMpAdxL1Cm5Bmi+3s3pdp UuWHAlE2xPEpRJ4hMgrdcwmH5L/cWxD/m9wkdbXoV9ydRms6sR1sOEO/wq1CiGwzGKqO yrmWJ4HhrK1b0Zc7y9FVKAMP8d60WY121UD0fj78Q5cU8bdRaYncGgasNuwnL6I9fJzr hgUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=RcKIj9/yjdtNTZk08Yt26jaU9oVCeuEBh05f7kP/j/A=; b=LRKBb0MQ14QBZd/kz7b1qq7RJVInU8h+Z4TVwvfTaei4YG6+WSDSnRdFZvMeWj6w8D y2MWvev+r7UWoXM96uD7mfJfQ+htP+FSefqk0uymH7ub6H0datwypr1ik/4Pz/Dihp7f JZ3FxyIblpmyJgqVJKiZI5xhuRPJDOHwPuLpr2dcUA+o9o2qhci3ubn3ABzKNmgE8NTv nMAwfcjZskinHKKLr3G31h5I+s/qDNiZc9yJqCrn629MwC9673UJz+WHhTTAPwUbtm3S wArb0lucfGBESt+21XGnqPEz/gghxugHhSq7EO3FeaSyYAAxWaioYUV0C34NZGaSYrcS Y/8w== X-Gm-Message-State: AE9vXwMOmfQBrpiLsKsu6YHNY7Ixz/5fApHcT2l7QhWUAcYsxI5N5E7/AYktkN7greHTxEx24oEaGm0N9uL12Q== X-Received: by 10.36.14.68 with SMTP id 65mr1547575ite.99.1474344224001; Mon, 19 Sep 2016 21:03:44 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Mon, 19 Sep 2016 21:03:43 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <201609192043.u8JKh3jv040006@repo.freebsd.org> References: <201609192043.u8JKh3jv040006@repo.freebsd.org> From: Warner Losh Date: Mon, 19 Sep 2016 22:03:43 -0600 X-Google-Sender-Auth: vRz_k3qA_36jhj5gZni4ERV7fcg Message-ID: Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr To: "Conrad E. Meyer" Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 04:03:45 -0000 On Mon, Sep 19, 2016 at 2:43 PM, Conrad E. Meyer wrote: > Author: cem > Date: Mon Sep 19 20:43:03 2016 > New Revision: 305998 > URL: https://svnweb.freebsd.org/changeset/base/305998 > > Log: > Move sys/capsicum.h includes after types.h or param.h > > This is not actually documented or even implied in style(9). Make the change > to match convention. Someone should document this convention in style(9). style(9) should be read as an annotated example. It comes first in the example, therefore, it's convention. It is documented, just poorly. There's many examples in style(9) that are treated this way and it takes much careful study to understand it. It's tribal knowledge, and sometimes the only way to learn is to transgress. Attempts to modify style(9) are fraught with politics, intrigue and generally a lot of flames even when all that's being done is codifying existing practice. When I tried to do this last it was a shit storm, and generally things devolve into a shit storm with no real gain. Warner