From owner-freebsd-current@FreeBSD.ORG  Sat Aug 27 15:16:54 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3811710656D2;
	Sat, 27 Aug 2011 15:16:54 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 081408FC19;
	Sat, 27 Aug 2011 15:16:53 +0000 (UTC)
Received: from sa-nc-common-23.static.jnpr.net (natint3.juniper.net
	[66.129.224.36]) (authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id p7RFGkBt098479
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sat, 27 Aug 2011 08:16:52 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1244.3)
Content-Type: text/plain; charset=windows-1252
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <4E580B14.7090208@FreeBSD.org>
Date: Sat, 27 Aug 2011 08:16:40 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <1A828073-1D5F-4850-9379-4AB62CF3DAE3@xcllnt.net>
References: <4E580B14.7090208@FreeBSD.org>
To: Andriy Gapon <avg@freebsd.org>
X-Mailer: Apple Mail (2.1244.3)
Cc: FreeBSD-Current <freebsd-current@freebsd.org>,
	Marcel Moolenaar <marcel@freebsd.org>
Subject: Re: possible mountroot regression
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2011 15:16:54 -0000


On Aug 26, 2011, at 2:07 PM, Andriy Gapon wrote:

>=20
> It seems that after the introduction of the mountroot scripting =
language a user
> now has exactly one chance to try to specify a correct root device at =
the
> mountroot prompt.  I am not sure that that is convenient/enough.

This is no different from before.

> I suspect that the following code is the cause:
>=20
> static void
> vfs_mountroot_conf0(struct sbuf *sb)
> {
>        char *s, *tok, *mnt, *opt;
>        int error;
>=20
>        sbuf_printf(sb, ".onfail panic\n");
> =85

Yes.

It is certainly a behavior we can improve upon. It's
rather annoying to get a panic on a typo. However,
we must remain cognizant of the fact that an immediate
hard failure is what's needed at times.

Maybe a good approach is to change to ".onfail retry"
and extend the root mount prompt with a reboot command,
so that the user/operator is does not have to worry
about typos *and* don't have to trigger a panic just
so that he/she can initiate a reboot.

Thoughts?

--=20
Marcel Moolenaar
marcel@xcllnt.net