From owner-cvs-all  Thu Dec  9 14: 1:35 1999
Delivered-To: cvs-all@freebsd.org
Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8535F157DA; Thu,  9 Dec 1999 14:00:53 -0800 (PST)
	(envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
	by gndrsh.dnsmgr.net (8.9.3/8.9.3) id OAA03662;
	Thu, 9 Dec 1999 14:00:52 -0800 (PST)
	(envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <199912092200.OAA03662@gndrsh.dnsmgr.net>
Subject: Re: cvs commit: src/sys/net route.c
In-Reply-To: <199912091709.JAA41440@freefall.freebsd.org> from John Polstra at "Dec 9, 1999 09:09:39 am"
To: jdp@FreeBSD.org (John Polstra)
Date: Thu, 9 Dec 1999 14:00:52 -0800 (PST)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, jkh@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> jdp         1999/12/09 09:09:39 PST
> 
>   Modified files:
>     sys/net              route.c 
>   Log:
>   Fix a route table leak in rtalloc() and rtalloc_ign().  It is
>   possible for ro->ro_rt to be non-NULL even though the RTF_UP flag
>   is cleared.  (Example: a routing daemon or the "route" command
>   deletes a cloned route in active use by a TCP connection.)  In that
>   case, the code was clobbering a reference to the routing table
>   entry without decrementing the entry's reference count.
>   
>   The splnet() call probably isn't needed, but I haven't been able
>   to prove that yet.  It isn't significant from a performance standpoint
>   since it is executed very rarely.
>   
>   Reviewed by:	wollman and others in the freebsd-current mailing list
>   
>   Revision  Changes    Path
>   1.57      +13 -6     src/sys/net/route.c

John, Jordan, can we get a MFC for this, this leak has heavily effected the
-stable branch for some time and it would be nice to not have it in 3.4.


-- 
Rod Grimes - KD7CAX @ CN85sl - (RWG25)               rgrimes@gndrsh.dnsmgr.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message