From owner-svn-src-all@FreeBSD.ORG Sun Jun 20 02:21:53 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D5FD1065670; Sun, 20 Jun 2010 02:21:53 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 390098FC08; Sun, 20 Jun 2010 02:21:52 +0000 (UTC) Received: from lawrence1.loshell.room52.net (unknown [59.167.184.191]) by lauren.room52.net (Postfix) with ESMTPSA id 7B2007E84A; Sun, 20 Jun 2010 12:21:51 +1000 (EST) Message-ID: <4C1D7B3B.8080609@freebsd.org> Date: Sun, 20 Jun 2010 12:21:47 +1000 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-AU; rv:1.9.1.9) Gecko/20100405 Thunderbird/3.0.4 MIME-Version: 1.0 To: Rui Paulo References: <201006141537.o5EFbnTD093866@svn.freebsd.org> <4C1C3162.60300@freebsd.org> <4C1D000C.8090807@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r209158 - in head/contrib/wpa: hostapd hostapd/doc src/common src/crypto src/drivers src/eap_common src/eap_peer src/eap_server src/eapol_supp src/hlr_auc_gw src/l2_packet src/radius sr... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jun 2010 02:21:53 -0000 On 06/20/10 05:22, Rui Paulo wrote: > Lawrence, > I don't see the point in enabling svn:keywords in vendor code. It's actually a good thing that radiotap.h doesn't get expanded. Rui, please accept my apologies. I *actually* understand the problem now as opposed to that lame 3am attempt earlier this morning. I was confused why vendor code would have $FreeBSD$ in it at all (thinking it was somehow a special case) which is why I thought you needed to set the keywords on the two radiotap.h files. I realise now that it's perfectly legit as it is and is that way because Sam pushed that code with the expanded keyword upstream and now we're importing it back in. The real problem is that Hg doesn't know about the svn autoprops during the conversion and my Hg keyword expansion config for $FreeBSD$ doesn't know to ignore $FreeBSD$ in contrib/*. Mea culpa and very sorry for lowering the SNR. Cheers, Lawrence