From owner-svn-src-all@freebsd.org Tue Sep 3 11:45:32 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8226AD7B32; Tue, 3 Sep 2019 11:45:32 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46N4rq0zN8z4Dnt; Tue, 3 Sep 2019 11:45:30 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 4E3163C0199; Tue, 3 Sep 2019 11:45:23 +0000 (UTC) Date: Tue, 3 Sep 2019 11:45:23 +0000 From: Brooks Davis To: Shawn Webb Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903114523.GA68094@spindle.one-eyed-alien.net> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <20190903113505.ckbx5i34onmin557@mutt-hbsd> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 46N4rq0zN8z4Dnt X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-7.43 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.954,0]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; IP_SCORE(-3.57)[ip: (-9.32), ipnet: 199.48.128.0/22(-4.64), asn: 36236(-3.86), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 11:45:32 -0000 --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > Hey Mateusz, >=20 > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > Author: mjg > > Date: Tue Sep 3 04:16:30 2019 > > New Revision: 351729 > > URL: https://svnweb.freebsd.org/changeset/base/351729 > >=20 > > Log: > > Add sysctlbyname system call > > =20 > > Previously userspace would issue one syscall to resolve the sysctl an= d then > > another one to actually use it. Do it all in one trip. > > =20 > > Fallback is provided in case newer libc happens to be running on an o= lder > > kernel. > > =20 > > Submitted by: Pawel Biernacki > > Reported by: kib, brooks > > Differential Revision: https://reviews.freebsd.org/D17282 > >=20 > > Modified: > ... snip ... > > head/sys/sys/param.h >=20 > ... snip ... >=20 > >=20 > > Modified: head/sys/sys/param.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r351728) > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r351729) > > @@ -60,7 +60,7 @@ > > * in the range 5 to 9. > > */ > > #undef __FreeBSD_version > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers */ > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers */ >=20 > To an outsider, it seems that __FreeBSD_version tends to be bumped in > a separate commit. Am I remembering that right? It should be bumped in the same commit, but people forget or the bump they have in their review turns into a no-op because someone else does a bump in the interim (the latter has bit me several times). =20 -- Brooks --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJdblJSAAoJEKzQXbSebgfAHnAH/iTwzH5oytRHj7/4d3ztHjKH SfW9Y7YTrAK0rIbDADiB3tU0BPjGGx6ogUMm/Cjly2NDEhVu+b4roVF+UOanp3X0 OoTwExFm+igBtctveuzseAozqnx3wVUDEvjvyzq0XtfPgC/Wnij84WK/rtyybdeg tHunIH1TDbWHZnRLhR+mZrqXcraqYFej72aSa/nY+kjBkALENuynGS/ix636/QTe HRpveQZARezpr9B/aObmb7/SajqQZq9k5jZEsRd5FoE2ECaYe8ys+EVioP7Wo05W jJ4k8Dn/yAHahTabaKctQyb4Wej7ynOjsC/aOXeXS4SYzVor89zc/qZ0jEYutvI= =97Wz -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--