From owner-freebsd-chromium@FreeBSD.ORG Sun Jul 28 18:30:26 2013 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CCB4B5F8; Sun, 28 Jul 2013 18:30:26 +0000 (UTC) (envelope-from geo.liaskos@gmail.com) Received: from mail-ea0-x22d.google.com (mail-ea0-x22d.google.com [IPv6:2a00:1450:4013:c01::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 37AE924E9; Sun, 28 Jul 2013 18:30:26 +0000 (UTC) Received: by mail-ea0-f173.google.com with SMTP id g10so2514224eak.32 for ; Sun, 28 Jul 2013 11:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Mp8ln88c+he65+0o/SjAh6QVF73NwCbjOTt5Nz3lAMI=; b=sfdjNkbs+goWjIw0ojJQLk26H3At3CfskzgsrZyGu5E3zU+bMAF20jAoGbUTPKWnQh fqndOwyHV7VNdghgd0hemoSyh6x8obb0cNEXugK/typo+NPp0dNlcIrn3F709E1BSkNZ /I4DGTs2mpowpnQClECxr1ICPPmg4jXVUT/BVDrMtxKoVgH/LbuJcKUBUnlohDrP1Yap pMWfyOhA0+qgNI2ISjjKCiL86SzjTmgJbqxOUKlndwHj+WziiZdDEpEL0fQYHjiUTxR4 5SZjoS+23Jrlk0wTJRFpC2+JNAR8oOoFJrDHH6pr/RefbpNfHRUMFBFLD+trqTlFgbF0 nPSQ== MIME-Version: 1.0 X-Received: by 10.15.98.3 with SMTP id bi3mr55164600eeb.124.1375036224489; Sun, 28 Jul 2013 11:30:24 -0700 (PDT) Received: by 10.223.127.133 with HTTP; Sun, 28 Jul 2013 11:30:24 -0700 (PDT) Received: by 10.223.127.133 with HTTP; Sun, 28 Jul 2013 11:30:24 -0700 (PDT) In-Reply-To: <51F5106D.9080806@freebsd.org> References: <51F3B731.7090608@cs.ucl.ac.uk> <20130728002022.GS81600@egr.msu.edu> <51F5106D.9080806@freebsd.org> Date: Sun, 28 Jul 2013 21:30:24 +0300 Message-ID: Subject: Re: compiling Chromium 28 with clang33 fixes "unclickable" links From: George Liaskos To: =?UTF-8?Q?Ren=C3=A9_Ladan?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-chromium@freebsd.org X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 18:30:26 -0000 It's possible that the latest clang patches that where committed brake chromium if NULL is not defined as nullptr. Let me test this before adding clang as dep, maybe we can get away by applying the extra clang patch on later base versions. On Jul 28, 2013 3:37 PM, "Ren=C3=A9 Ladan" wrote: > On 28-07-2013 02:20, Adam McDougall wrote: > > On Sat, Jul 27, 2013 at 01:04:01PM +0100, Brad Karp wrote: > > > > Given hope by Tony's experience, I tried building Chromium 28 on my > > 9.1-RELEASE amd64 box with clang33 instead of the default 9.1R clang > (3.1). > > > > Success here, too: building with clang33 fixes the "unclickable" link= s > > problem I and others had when building with 9.1R's default clang. > > > > Perhaps the port maintainer might consider requiring clang33 for thos= e > > who build with clang on 9.1R and earlier for the time being? > > > > -Brad, bkarp@cs.ucl.ac.uk > > > > After a brief test with https://scroner.com/~tony/chrome_test/ > > and nagios, I can confirm this. Thanks for the tip. > > I made trivial patch for this at > http://people.freebsd.org/~rene/patches/chromium-clang33.diff > > I think it would be good to commit this, I see similar non-clickable link= s. > > Ren=C3=A9 > _______________________________________________ > freebsd-chromium@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-chromium > To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.or= g > " >