From owner-cvs-src-old@FreeBSD.ORG Sun Apr 17 22:31:50 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED51B106564A for ; Sun, 17 Apr 2011 22:31:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DC9E98FC12 for ; Sun, 17 Apr 2011 22:31:50 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p3HMVoRk054656 for ; Sun, 17 Apr 2011 22:31:50 GMT (envelope-from dougb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p3HMVoWQ054655 for cvs-src-old@freebsd.org; Sun, 17 Apr 2011 22:31:50 GMT (envelope-from dougb@repoman.freebsd.org) Message-Id: <201104172231.p3HMVoWQ054655@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to dougb@repoman.freebsd.org using -f From: Doug Barton Date: Sun, 17 Apr 2011 22:31:36 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc rc.subr X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 22:31:51 -0000 dougb 2011-04-17 22:31:36 UTC FreeBSD src repository Modified files: etc rc.subr Log: SVN rev 220760 on 2011-04-17 22:31:36Z by dougb The change in r206686 to allow the stop argument to work for a service that is running even though not _enable'd had an annoying side effect. If the service was already started at boot time by another means when the related script came around again in rcorder it would start again, regardless of _enable, because there was a valid pid. [1] So, split the test into 2 parts, one for (!rcvar && !stop), and one for (stop && !valid_pid). This preserves the behavior from r206686 while preventing the undesired side effect. PR: conf/156427 [1] Submitted by: Eugene Grosbein [1] Revision Changes Path 1.107 +2 -1 src/etc/rc.subr