Date: Tue, 17 Jan 2012 14:34:03 -0500 From: John Baldwin <jhb@freebsd.org> To: Scott Long <scottl@samsco.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>, Colin Percival <cperciva@freebsd.org> Subject: Re: svn commit: r230125 - head/sys/kern Message-ID: <201201171434.03633.jhb@freebsd.org> In-Reply-To: <CF79A730-86D4-4A73-BDFF-C3F1B93EA330@samsco.org> References: <201201150709.q0F79Iif067938@svn.freebsd.org> <201201171008.28752.jhb@freebsd.org> <CF79A730-86D4-4A73-BDFF-C3F1B93EA330@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, January 17, 2012 2:22:26 pm Scott Long wrote: > On Jan 17, 2012, at 8:08 AM, John Baldwin wrote: > > On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: > >> On 01/15/12 15:28, John Baldwin wrote: > >>> On 1/15/12 2:09 AM, Eitan Adler wrote: > >>>> Log: > >>>> - Fix undefined behavior when device_get_name is null > >>>> - Make error message more informative > >>> > >>> The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL, > >>> so that wasn't undefined behavior. Printing out the driver name is a useful > >>> change, but the "(unknown)" bits are just noise as it isn't clear that > >>> "(unknown)" is substantially better than "(null)". > >> > >> I think the change from "(null)" to "(unknown)" is useful, since when I see > >> "(null)" printed my immediate thought is "looks like there's a bug I need to > >> track down here". > > > > The entire printf is "there's a bug I need to track down here". (null) > > explicitly tells me that device_get_name() is NULL when looking at the printf > > to see what it means. Having it be (unknown) tells me the same exact thing, > > but only after I've parsed an extra 2-3 lines of code to figure out what > > (unknown) stands for. > > > > I like that change. "null" is ambiguous for those who aren't intimately familiar with the bus code. Bruce suggested in another e-mail that the entire printf should be using device_printf() instead which would also use 'unknown', but spelled slightly differently (and consistent with other device messages). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201171434.03633.jhb>