From owner-freebsd-dtrace@freebsd.org Tue Feb 7 18:10:47 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 049F1CD54C8 for ; Tue, 7 Feb 2017 18:10:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF7B71440 for ; Tue, 7 Feb 2017 18:10:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v17IAk6o078178 for ; Tue, 7 Feb 2017 18:10:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-dtrace@FreeBSD.org Subject: [Bug 216871] www/firefox: DTRACE=on no longer builds on 12.0-CURRENT Date: Tue, 07 Feb 2017 18:10:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: markj@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 18:10:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216871 --- Comment #2 from Mark Johnston --- The problem seems to be related to GNU ld (I had only tested the build with lld) and -ffunction-sections. Two objects that get linked into libxul.= so contain the same weak symbol. There's a DTrace probe in the corresponding function: > readelf -s Unified_cpp_js_src27.o | grep _ZN2js14NewObjectCache16newObjec= tFromHitEP9JSC 747: 0000000000000000 518 FUNC WEAK HIDDEN 152 _ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE 1261: 0000000000000000 518 FUNC GLOBAL HIDDEN 152 $dtrace6188451._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE > readelf -s jsarray.o | grep _ZN2js14NewObjectCache16newObjectFromHitEP9JSC 382: 0000000000000000 518 FUNC WEAK HIDDEN 405 _ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE 567: 0000000000000000 518 FUNC GLOBAL HIDDEN 405 $dtrace6195329._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE > readelf -s js-dtrace.o | grep _ZN2js14NewObjectCache16newObjectFromHitEP9= JSC 44: 0000000000000000 0 FUNC GLOBAL DEFAULT UND $dtrace6188451._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE 57: 0000000000000000 0 FUNC GLOBAL DEFAULT UND $dtrace6195329._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE With r313262, we emit alises for the symbols. It seems that ld merges the sections, and ends up leaving one the aliases orphaned: > ld -r -o test.o jsarray.o Unified_cpp_js_src27.o > readelf -s test.o | grep _ZN2js14NewObjectCache16newObjectFromHitEP9JSC 1231: 0000000000000000 0 FUNC GLOBAL HIDDEN UND $dtrace6188451._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE 1438: 0000000000000000 518 FUNC GLOBAL HIDDEN 476 $dtrace6195329._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc1= 1InitialHeapE 1667: 0000000000000000 518 FUNC WEAK HIDDEN 476 _ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE However, the .SUNW_dof section has a relocation for this symbol, so the final link fails. I'm not sure if this behaviour is a bug in ld. It seems to me that we might be able address this by avoiding the "$dtrace" uniquifier for aliases of weak symbols. --=20 You are receiving this mail because: You are on the CC list for the bug.=