From owner-cvs-all Wed Jul 18 10:10:44 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.39]) by hub.freebsd.org (Postfix) with SMTP id 22C9F37B409 for ; Wed, 18 Jul 2001 10:10:38 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 759 invoked by uid 1000); 18 Jul 2001 17:14:48 -0000 Date: Wed, 18 Jul 2001 20:14:48 +0300 From: Peter Pentchev To: Mikhail Teterin Cc: Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kmod.mk Message-ID: <20010718201448.A635@ringworld.oblivion.bg> Mail-Followup-To: Mikhail Teterin , Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200107181456.f6IEujO87127@aldan.algebra.com> <3B55A656.25525440@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3B55A656.25525440@FreeBSD.org>; from sobomax@FreeBSD.org on Wed, Jul 18, 2001 at 06:08:06PM +0300 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jul 18, 2001 at 06:08:06PM +0300, Maxim Sobolev wrote: > Mikhail Teterin wrote: > > > On 18 Jul, Peter Pentchev wrote: > > > roam 2001/07/18 02:59:55 PDT > > > > > > Modified files: > > > sys/conf kmod.mk > > > Log: > > > Make sure that installing a module complains if the target modules > > > directory does not exist, instead of creating/overwriting a file > > > with the name of the (expected) directory. Yes, this deviates a bit > > > from nearly all other install targets in the tree, but let's face > > > it, removing a modules directory is not all that uncommon a mistake, > > > and finding a file with the contents of the last module installed is > > > a baaad surprise at boot time.. > > > > IMHO, the target directory should be a Makefile target of its own, a > > dependecy of the install target. Then parallel installs just might work. > > We have mtree(8) for that. Exactly. My commit only referenced a case when the user *mistakenly* removes the /modules/ (or /boot/kernel/ in -current) directory before attempting to install the new kernel. Even in this case, a parallel make shall just fail in a parallel manner :) The general agreement in kern/26317's followup discussion was that it is not the install target's job to ascertain that the target directory exists, rather it is the user/admin's job to ascertain that no one removes system directories. In the normal case, when the user has not tried to undo mtree(8)'s (or sysinstall's, for that matter) doings, the modules directory exists, and a parallel make succeeds (in a parallel manner ;). G'luck, Peter -- I had to translate this sentence into English because I could not read the original Sanskrit. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message