From owner-freebsd-bugs  Sat Apr  7  1:20:10 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 43A9137B423
	for <freebsd-bugs@hub.freebsd.org>; Sat,  7 Apr 2001 01:20:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f378K3R53066;
	Sat, 7 Apr 2001 01:20:03 -0700 (PDT)
	(envelope-from gnats)
Date: Sat, 7 Apr 2001 01:20:03 -0700 (PDT)
Message-Id: <200104070820.f378K3R53066@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Bruce Evans <bde@zeta.org.au>
Subject: Re: bin/26057: [PATCH] Minor ps(1) fixes
Reply-To: Bruce Evans <bde@zeta.org.au>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR bin/26057; it has been noted by GNATS.

From: Bruce Evans <bde@zeta.org.au>
To: dd@FreeBSD.ORG
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/26057: [PATCH] Minor ps(1) fixes
Date: Sat, 7 Apr 2001 18:13:38 +1000 (EST)

 On Fri, 6 Apr 2001 dd@FreeBSD.ORG wrote:
 
 > Synopsis: [PATCH] Minor ps(1) fixes
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: dd
 > State-Changed-When: Fri Apr 6 20:19:09 PDT 2001
 > State-Changed-Why: 
 > ps.c part committed by brian (1.37 of bin/ps/ps.c).  I'll update the
 > man page later today.
 
 The committed fix is half-baked at best.  It does't even remove the
 session keyword like the first version of the PR does.
 
 Kirk also removed the tsess pointer and keyword from everywhere except
 ps.1, but the PR doesn't mention it.  The log message for rev.1.25 of
 keyword.c says the following about the removal:
 
     kernel/user interface, specifically rusage and rtprio. It no
     longer contains proc, session, pcred, ucred, procsig, vmspace,
     pstats, mtx, sigiolst, klist, callout, pasleep, or mdproc. If
     any of these changed in size, ps, w, fstat, gcore, systat, and
     top would all stop working. The new structure has over 200 bytes
 
 This is incorrect for "session" in ps at least.  ps would not have
 stopped working if sizeof(struct session) changed, since it just
 printed the session pointer.
 
 Bruce
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message