From owner-svn-src-all@freebsd.org Tue Jul 14 11:33:43 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09F9599C6D6; Tue, 14 Jul 2015 11:33:43 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C068369; Tue, 14 Jul 2015 11:33:40 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA10783; Tue, 14 Jul 2015 14:33:39 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ZEySx-0000Vl-AS; Tue, 14 Jul 2015 14:33:39 +0300 Message-ID: <55A4F36F.8070009@FreeBSD.org> Date: Tue, 14 Jul 2015 14:33:03 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Slawa Olhovchenkov CC: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r285025 - vendor-sys/illumos/dist/uts/common/fs/zfs References: <201507021101.t62B1SlK075159@repo.freebsd.org> <20150712135246.GA43740@zxy.spb.ru> <55A4E40C.3090608@FreeBSD.org> <20150714111455.GH44094@zxy.spb.ru> In-Reply-To: <20150714111455.GH44094@zxy.spb.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 11:33:43 -0000 On 14/07/2015 14:14, Slawa Olhovchenkov wrote: > On Tue, Jul 14, 2015 at 01:27:24PM +0300, Andriy Gapon wrote: > >> On 12/07/2015 16:52, Slawa Olhovchenkov wrote: >>> On Thu, Jul 02, 2015 at 11:01:28AM +0000, Andriy Gapon wrote: >>> >>>> Author: avg >>>> Date: Thu Jul 2 11:01:27 2015 >>>> New Revision: 285025 >>>> URL: https://svnweb.freebsd.org/changeset/base/285025 >>>> >>>> Log: >>>> 6033 arc_adjust() should search MFU lists for oldest buffer when adjusting MFU size >>>> >>>> illumos/illumos-gate@31c46cf23cd1cf4d66390a983dc5072d7d299ba2 >>>> >>>> https://www.illumos.org/issues/6033 >>>> When we're looking for the list containing oldest buffer we never actually look >>>> at the MFU lists even when we try to evict from MFU. >>>> looks like a copy paste error, the fix is here: >>>> >>>> Reviewed by: Saso Kiselkov >>>> Reviewed by: Xin Li >>>> Reviewed by: Prakash Surya >>>> Approved by: Matthew Ahrens >>>> Author: Alek Pinchuk >>>> Obtained from: illumos >>>> >>>> Modified: >>>> vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c >>>> >>> >>> Can you see also at arc_init:4297? >>> I see double init arc_mfu_ghost->arcs_lists[i] and no init arc_anon. >>> This is correct? >>> >> >> There is no double initialization if you look harder, one initialization is for >> data and the other is for metadata. > > 4295: list_create(&arc_mfu_ghost->arcs_lists[i], sizeof (arc_buf_hdr_t), offsetof(arc_buf_hdr_t, b_arc_node)); > 4297: list_create(&arc_mfu_ghost->arcs_lists[i], sizeof (arc_buf_hdr_t), offsetof(arc_buf_hdr_t, b_arc_node)); > > I see two absolutly identical initialization Yes, this is a harmless duplication. >> Buffers in arc_anon state are not placed on a list. > > This is correct? Yes, this is correct. E.g. see arc_change_state(). > Or list initialization of arc_anon is missing? No, it's not needed. -- Andriy Gapon