From owner-freebsd-hackers@FreeBSD.ORG  Mon Sep 18 22:05:26 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7238E16A403
	for <freebsd-hackers@freebsd.org>; Mon, 18 Sep 2006 22:05:26 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8908A43D67
	for <freebsd-hackers@freebsd.org>; Mon, 18 Sep 2006 22:05:21 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8IM5Gdk079022;
	Mon, 18 Sep 2006 18:05:18 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Mon, 18 Sep 2006 17:50:57 -0400
User-Agent: KMail/1.9.1
References: <1158407656.3215.33.camel@berloga.shadowland>
	<20060917211905.GA64182@xor.obsecurity.org>
	<1158530904.3213.1.camel@berloga.shadowland>
In-Reply-To: <1158530904.3213.1.camel@berloga.shadowland>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="koi8-r"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200609181750.58145.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 18 Sep 2006 18:05:19 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/1893/Mon Sep 18 14:37:26 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Alex Lyashkov <umka@sevcity.net>, Kris Kennaway <kris@obsecurity.org>
Subject: Re: jail2 patchset 12
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2006 22:05:26 -0000

On Sunday 17 September 2006 18:08, Alex Lyashkov wrote:
> Thanks for you report. I really more test new jail2 API then old :(
> Please apply this patch.
> 
> # p4 diff -du kern_jail.c
> ==== //depot/projects/jail2/sys/kern/kern_jail.c#4 -
> /root/jail2/sys/kern/kern_jail.c ====
> @@ -316,6 +316,7 @@
>         if (error)
>                 return (error);
> 
> +       mtx_lock(&allprison_mtx);
>         pr = prison_find(uap->jid);
>         if (pr == NULL) {
>                 return (ESRCH);

Does this leak the lock in the ESRCH case now?
 
-- 
John Baldwin