From owner-svn-src-head@freebsd.org Thu Sep 29 12:50:18 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3AFDBEC405; Thu, 29 Sep 2016 12:50:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 330952D8; Thu, 29 Sep 2016 12:50:17 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA17145; Thu, 29 Sep 2016 15:50:10 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1bpamv-00001s-V1; Thu, 29 Sep 2016 15:50:09 +0300 Subject: Re: svn commit: r306425 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Alexander Motin , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201609290000.u8T00bYQ004671@repo.freebsd.org> From: Andriy Gapon Message-ID: Date: Thu, 29 Sep 2016 15:49:13 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <201609290000.u8T00bYQ004671@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 12:50:18 -0000 On 29/09/2016 03:00, Alexander Motin wrote: > Author: mav > Date: Thu Sep 29 00:00:37 2016 > New Revision: 306425 > URL: https://svnweb.freebsd.org/changeset/base/306425 > > Log: > MFV r306423: 7402 Create tunable to ignore hole_birth feature > > Until we can resolve the numerous hole_birth bugs that have cropped up > recently, and come up with a way going forwards to protect users from > corruption, we should disable the hole_birth feature. Using a tunable > allows those who are confident that their data is correct to continue to > take advantage of the feature. > > Closes #188 > > Reviewed by: Matthew Ahrens > Author: Paul Dagnelie > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c > Directory Properties: > head/sys/cddl/contrib/opensolaris/ (props changed) > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c Wed Sep 28 23:54:47 2016 (r306424) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c Thu Sep 29 00:00:37 2016 (r306425) > @@ -40,6 +40,11 @@ > #include > > int32_t zfs_pd_bytes_max = 50 * 1024 * 1024; /* 50MB */ > +boolean_t send_holes_without_birth_time = B_TRUE; > + > +SYSCTL_DECL(_vfs_zfs); > +SYSCTL_UINT(_vfs_zfs, OID_AUTO, send_holes_without_birth_time, CTLFLAG_RWTUN, > + &send_holes_without_birth_time, 0, "Send holes without birth time"); I think that this should be guarded with _KERNEL. > typedef struct prefetch_data { > kmutex_t pd_mtx; > @@ -254,7 +259,8 @@ traverse_visitbp(traverse_data_t *td, co > * > * Note that the meta-dnode cannot be reallocated. > */ > - if ((!td->td_realloc_possible || > + if (!send_holes_without_birth_time && > + (!td->td_realloc_possible || > zb->zb_object == DMU_META_DNODE_OBJECT) && > td->td_hole_birth_enabled_txg <= td->td_min_txg) > return (0); > -- Andriy Gapon