From owner-svn-src-head@freebsd.org  Sun Dec 24 07:11:32 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70310EA1A9B;
 Sun, 24 Dec 2017 07:11:32 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4251A6C472;
 Sun, 24 Dec 2017 07:11:31 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vBO7BNLw045405;
 Sat, 23 Dec 2017 23:11:23 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vBO7BNRG045404;
 Sat, 23 Dec 2017 23:11:23 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201712240711.vBO7BNRG045404@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r327140 - head/sbin/ipfw
In-Reply-To: <201712240155.vBO1tCxX099433@repo.freebsd.org>
To: "Andrey V. Elsukov" <ae@freebsd.org>
Date: Sat, 23 Dec 2017 23:11:23 -0800 (PST)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 07:11:32 -0000

> Author: ae
> Date: Sun Dec 24 01:55:12 2017
> New Revision: 327140
> URL: https://svnweb.freebsd.org/changeset/base/327140
> 
> Log:
>   Fix rule number truncation, use uint16_t type to specify rulenum.
>   
>   PR:		224555
>   MFC after:	1 week
> 
> Modified:
>   head/sbin/ipfw/ipfw2.c
> 
> Modified: head/sbin/ipfw/ipfw2.c
> ==============================================================================
> --- head/sbin/ipfw/ipfw2.c	Sun Dec 24 01:16:28 2017	(r327139)
> +++ head/sbin/ipfw/ipfw2.c	Sun Dec 24 01:55:12 2017	(r327140)
> @@ -2256,12 +2256,13 @@ do_range_cmd(int cmd, ipfw_range_tlv *rt)
>  void
>  ipfw_sets_handler(char *av[])
>  {
> -	uint32_t masks[2];
> -	int i;
> -	uint8_t cmd, rulenum;
>  	ipfw_range_tlv rt;
>  	char *msg;
>  	size_t size;
> +	uint32_t masks[2];
> +	int i;

Why do these 2 lines show up as null changes in the diff????
I can not see any change, not even white space.

> +	uint16_t rulenum;
> +	uint8_t cmd;
>  
>  	av++;
>  	memset(&rt, 0, sizeof(rt));

-- 
Rod Grimes                                                 rgrimes@freebsd.org