From nobody Tue Mar 4 15:47:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z6g6P2LHnz5qGh9; Tue, 04 Mar 2025 15:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z6g6N09tqz42cy; Tue, 04 Mar 2025 15:47:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741103228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GCKTucyDM7QJTG+rPa0kLCMc+E4B7rBaoczZaOQK9Xk=; b=tdfcHv+LozoRXqhI5K5HaNf6Awrl1yy1KJ9NpdTpiZSFK8nELrhQhW4m+4n1NEbkT9vhN3 bzLy4LkUyPbmiSpZZ8R8r6hD1wcR6i5zSL2ouFFdbpFh8ZhEj8h9OPEgMdpQb70HJJ5h2I 8mEQkx4S+QWtZfzIUXPoFf7qRtKApnXdh6u4yI9aFkBCvngXZ4YRyWuXHkXDrw9+IVfMNt d40+vP+auytikKpXJvBHMAfW3/kIPHl0joA1jrl1cDJUhGNzqmbTO3DLD8QJRpa/7HkZsZ RUrT1ENHmeQJbDWOhhsYd+IQ3PiIZ+lTaTECOTudscQb9D2ocshK4PzJXrN+6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741103228; a=rsa-sha256; cv=none; b=epJZbbnXS+ES/0lIETY0jMixARfzqeatlqQHimSa3lgMLVdYEA3scPZNPxNo0c50hS+/Y+ WkjppCf6PoS7VD/zKanLT8Nl++w6BOO0gT8PemwUsCG3Dt8aACQOQovQqALpBhYYk/vHBY O/v5YtZ18l4vxFATRvG42HwS3TppuIqFDVZAU4YfQjh0SLgUGrwqul1ZNqR3RoXybREpCq /A83V7f6j187KOY4nZ2q5O0TJ2pP7A+X/zY1x/1g5YK2ua04UlwwZedsw/Kcv62LsfVpsW Tr9WN/H7z/rheojFgTzNiww4ChugTq2fo+hmTZ/PU81RkG53h7Hhvem7n4Cm6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741103228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GCKTucyDM7QJTG+rPa0kLCMc+E4B7rBaoczZaOQK9Xk=; b=UHdKAWJ6DOOqiG2rZeiBvJuzh5g9rrw7+w3o0DerTISulLHYaNI7vdwD14tQ2/10GnvdGJ iKJjW38A8Z2bPP6RMrKktrbtJYBaNVLe5kAAcyR/rV1X+4OGplDJJHGn3fyT3rre+q6rH9 NmON21RGDiteAj1AQRvPa/LhdC4xa3G1ilrtzwS8EPP4JfYmyhagutF5tKMWsyGaU4uoBG D9GaDcj0fx8SuF8umYGOhyC2PzvW3v9O1AGkwWzmyOFgE2sWpm2Lwy0wXegnWa2snZYtwz NK7GZzcFzbGvSW4p6qKHBOGhJW1lUjreLhqHUbSTwDkdqYbCLbTgvQW5EPoGKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z6g6M6qdjz8H7; Tue, 04 Mar 2025 15:47:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 524Fl7s9050169; Tue, 4 Mar 2025 15:47:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 524Fl7qZ050166; Tue, 4 Mar 2025 15:47:07 GMT (envelope-from git) Date: Tue, 4 Mar 2025 15:47:07 GMT Message-Id: <202503041547.524Fl7qZ050166@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 127a39c54c2b - stable/14 - sound: Update comment and channel insertion in vchan_create() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 127a39c54c2bb56189bd44353d54e34c8ff220bd Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=127a39c54c2bb56189bd44353d54e34c8ff220bd commit 127a39c54c2bb56189bd44353d54e34c8ff220bd Author: Christos Margiolis AuthorDate: 2025-02-25 11:44:30 +0000 Commit: Christos Margiolis CommitDate: 2025-03-04 15:46:06 +0000 sound: Update comment and channel insertion in vchan_create() The comment and rationale behind choosing CHN_INSERT_SORT_DESCEND() instead of CHN_INSERT_SORT_ASCEND() are no longer relevant as of FILLME ("sound: Allocate vchans on-demand"). Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D48962 (cherry picked from commit 2868776c9c6f5313a5676786f642b766f103d780) --- sys/dev/sound/pcm/vchan.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/dev/sound/pcm/vchan.c b/sys/dev/sound/pcm/vchan.c index 45f0a8b00bd2..27739fe68852 100644 --- a/sys/dev/sound/pcm/vchan.c +++ b/sys/dev/sound/pcm/vchan.c @@ -644,12 +644,7 @@ vchan_create(struct pcm_channel *parent, struct pcm_channel **child) PCM_UNLOCK(d); CHN_LOCK(parent); - /* - * Add us to our parent channel's children in reverse order - * so future destruction will pick the last (biggest number) - * channel. - */ - CHN_INSERT_SORT_DESCEND(parent, ch, children); + CHN_INSERT_SORT_ASCEND(parent, ch, children); *child = ch;