From owner-cvs-src@FreeBSD.ORG  Thu Dec  6 12:57:04 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1B4516A41A;
	Thu,  6 Dec 2007 12:57:04 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id A7FB513C459;
	Thu,  6 Dec 2007 12:57:04 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id A2DA42082;
	Thu,  6 Dec 2007 13:56:54 +0100 (CET)
X-Spam-Tests: AWL
X-Spam-Learn: disabled
X-Spam-Score: -0.1/3.0
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no
Received: from ds4.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 34C7423CB;
	Thu,  6 Dec 2007 10:16:53 +0100 (CET)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 0C5A384486; Thu,  6 Dec 2007 10:16:53 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Bruce Evans <brde@optusnet.com.au>
References: <200711192157.lAJLvSu6057416@repoman.freebsd.org>
	<868x4beu46.fsf@ds4.des.no> <20071204115427.D3192@delplex.bde.org>
Date: Thu, 06 Dec 2007 10:16:52 +0100
In-Reply-To: <20071204115427.D3192@delplex.bde.org> (Bruce Evans's message of
	"Tue\, 4 Dec 2007 12\:00\:57 +1100 \(EST\)")
Message-ID: <86odd4chdn.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cvs-src@freebsd.org, src-committers@freebsd.org,
	Olivier Houchard <cognet@freebsd.org>, cvs-all@freebsd.org
Subject: Re: cvs commit: src/lib/libc/gen closedir.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2007 12:57:05 -0000

Bruce Evans <brde@optusnet.com.au> writes:
> dd_lock cannot be declared as struct pthread_mutex *, since pthread_mutex
> is not permitted in the application namespace of dirent.h.  dirent.h
> is (was) careful about namespaces.  E.g., it keeps out of the application
> namespace for its own struct _dirdesc.  This doesn't work for pthread_mut=
ex
> since that is misdesigned.  (I think pthread_mutex_t is supposed to
> hide the implementation and reduce namespace problems, but struct
> pthread was only declared in <pthread.h> where it is permitted in the
> namespace, so <pthread.h> doesn't bother naming it struct _pthread_mutex.
> Other headers can't define it with a different name (tag) because differe=
nt
> tags give different structs.)

Since struct pthread_mutex is not part of the API, how about simply
renaming it to struct _pthread_mutex to circumvent the namespace issues?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no