From owner-cvs-all  Wed Jun  6 18:23:21 2001
Delivered-To: cvs-all@freebsd.org
Received: from nebula.cybercable.fr (d010.dhcp212-198-128.noos.fr [212.198.128.10])
	by hub.freebsd.org (Postfix) with ESMTP
	id E9DDC37B401; Wed,  6 Jun 2001 18:23:17 -0700 (PDT)
	(envelope-from mux@qualys.com)
Received: (from mux@localhost)
	by nebula.cybercable.fr (8.11.3/8.11.3) id f571NGI17052;
	Thu, 7 Jun 2001 03:23:16 +0200 (CEST)
	(envelope-from mux)
Date: Thu, 7 Jun 2001 03:23:15 +0200
From: Maxime Henrion <mux@qualys.com>
To: cvs-all@FreeBSD.org
Cc: Peter Wemm <peter@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/ata ata-disk.c atapi-all.c src/sys/dev/sound/pcm sound.c src/sys/kern kern_ktr.c kern_linker.c kern_malloc.c subr_witness.c uipc_mbuf.c uipc_socket2.c src/sys/net if_loop.c src/sys/netinet tcp_subr.c ...
Message-ID: <20010607032315.A625@nebula.cybercable.fr>
References: <200106062217.f56MH9F00621@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200106062217.f56MH9F00621@freefall.freebsd.org>; from peter@FreeBSD.ORG on Wed, Jun 06, 2001 at 03:17:09PM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Peter Wemm wrote:
> peter       2001/06/06 15:17:09 PDT
> 
>   Modified files:
>     sys/dev/ata          ata-disk.c atapi-all.c 
>     sys/dev/sound/pcm    sound.c 
>     sys/kern             kern_ktr.c kern_linker.c kern_malloc.c 
>                          subr_witness.c uipc_mbuf.c uipc_socket2.c 
>     sys/net              if_loop.c 
>     sys/netinet          tcp_subr.c 
>     sys/sys              kernel.h 
>   Log:
>   Make the TUNABLE_*() macros look and behave more consistantly like the
>   SYSCTL_*() macros.  TUNABLE_INT_DECL() was an odd name because it didn't
>   actually declare the int, which is what the name suggests it would do.

This breaks kernel compilation.  The problem is that the second
parameter of the TUNABLE_INT() macro is used to generate a function
name, and that you changed this second parameter in all calls from foo
to &foo.

I reverted this and my kernel compiled again.

If you want to keep this way of calling the macro, perhaps the first
parameter can be used for that.

Cheers,
Maxime
-- 
Don't be fooled by cheap finnish imitations ; BSD is the One True Code
Key fingerprint = F9B6 1D5A 4963 331C 88FC  CA6A AB50 1EF2 8CBE 99D6
Public Key : http://www.epita.fr/~henrio_m/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message