From owner-svn-ports-head@freebsd.org Sun Oct 4 02:50:18 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8B11A0E809; Sun, 4 Oct 2015 02:50:18 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com [IPv6:2607:f8b0:400e:c03::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8A74154E; Sun, 4 Oct 2015 02:50:18 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by pacex6 with SMTP id ex6so142236958pac.0; Sat, 03 Oct 2015 19:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=FIzp2E3/UUVhve0z/86MkivmMFa1mnBTdJnkzsqWqtI=; b=UXZnC3853Grl5uM5qfvHgwSy3x0dcRtbSk6VEefgMgRbmpqMJInu12Wb0yOcBj4sE3 K3ZV//XSX3w7iSyAHXmcup4KMPkiGbEX+g30UVEL5S3ew2pojgk8TlnaBEcojSmGSbLl wTw0dWj0p4q3qtp9+YIu8z1nkYZptt5sEzB6TBjjGr1t2ezi7qBJMAw68IgIg1nytQE6 7FBaQfSdlY0be2w4vRb66A+kIlIyrMG/zfS11tqnKohzF7TW4h1aFxkDRYYshKDAzHtc HBqEtQJ0RMccRtLDH63vQEy2AVPIxPN2Mkjv6BYOLgGRqr5ffr6CBCrm+wKy1/Z2wLBW Kf+A== X-Received: by 10.66.216.39 with SMTP id on7mr30137657pac.73.1443927017429; Sat, 03 Oct 2015 19:50:17 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01::8? (2001-44b8-31ae-7b01-0000-0000-0000-0008.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01::8]) by smtp.gmail.com with ESMTPSA id fa14sm19956366pac.8.2015.10.03.19.50.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Oct 2015 19:50:16 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r398483 - head/devel/py-protobuf References: <201510031707.t93H7ZXA008510@repo.freebsd.org> To: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Jan Beich From: Kubilay Kocak Message-ID: <561093E3.50701@FreeBSD.org> Date: Sun, 4 Oct 2015 13:50:11 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Thunderbird/41.0 MIME-Version: 1.0 In-Reply-To: <201510031707.t93H7ZXA008510@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Oct 2015 02:50:18 -0000 On 4/10/2015 4:07 AM, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Sat Oct 3 17:07:34 2015 > New Revision: 398483 > URL: https://svnweb.freebsd.org/changeset/ports/398483 > > Log: > - Convert to new test framework > - Add NO_ARCH > > Modified: > head/devel/py-protobuf/Makefile > > Modified: head/devel/py-protobuf/Makefile > ============================================================================== > --- head/devel/py-protobuf/Makefile Sat Oct 3 17:07:29 2015 (r398482) > +++ head/devel/py-protobuf/Makefile Sat Oct 3 17:07:34 2015 (r398483) > @@ -16,6 +16,9 @@ BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}go > protoc:${PORTSDIR}/devel/protobuf > RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}google-apputils>=0:${PORTSDIR}/devel/py-google-apputils > > +DO_MAKE_TEST= ${PYTHON_CMD} ${PYDISTUTILS_SETUP} > +NO_ARCH= yes > +TEST_TARGET= test These bits *SHOULD* be set by python.mk, at least for the 'canonical' setuptools test targetcase, and only *if* tests are explicitly enabled in the port. See https://reviews.freebsd.org/D3791 CC'ing Jan > USE_PYTHON= autoplist distutils > USES= python tar:bzip2 > WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}/python > @@ -26,7 +29,4 @@ USE_GITHUB= yes > post-patch: > @${MKDIR} ${WRKSRC}/google/protobuf/compiler/ > > -regression-test test: build > - cd ${WRKSRC}/ && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test > - > .include >