Date: Wed, 04 Jan 2006 00:16:20 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Diomidis Spinellis <dds@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c Message-ID: <88559.1136330180@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 03 Jan 2006 21:58:22 GMT." <200601032158.k03LwMGP031138@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200601032158.k03LwMGP031138@repoman.freebsd.org>, Diomidis Spinellis writes: >dds 2006-01-03 21:58:22 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_syscalls.c > Log: > Normalize the tv_usec part of the utimes(2) arguments to ensure > that a file's atime and mtime are only set to correct fractional > second values (0-999999000ns with the current interface). > Prior to this change users could create files with values outside > that range. Moreover, on 32-bit machines tv_usec offsets larger than > 4.3s would result in an unnormalized AND wrong timestamp value, > due to overflow. I think this is wrong. We should return EINVAL if the fractional part is not correct. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88559.1136330180>