From nobody Mon May 31 10:01:14 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 267C6DF6443 for ; Mon, 31 May 2021 10:01:33 +0000 (UTC) (envelope-from arnaud.ysmal@stormshield.eu) Received: from work.stormshield.eu (gwlille.netasq.com [91.212.116.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FtrRJ1zNgz4WSB for ; Mon, 31 May 2021 10:01:31 +0000 (UTC) (envelope-from arnaud.ysmal@stormshield.eu) Received: from work.stormshield.eu (localhost.localdomain [127.0.0.1]) by work.stormshield.eu (Postfix) with ESMTPS id 02E4037603EA; Mon, 31 May 2021 12:01:15 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by work.stormshield.eu (Postfix) with ESMTP id DD50C37602DC; Mon, 31 May 2021 12:01:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 work.stormshield.eu DD50C37602DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stormshield.eu; s=BBC9ECEA-016A-11EA-9CC1-8A393C11FBBB; t=1622455274; bh=56bfQ929CQZqhzVvV2Ej+sOmRQtHfuNMdqd2WPigdno=; h=Date:From:To:Message-ID:MIME-Version; b=dGihcyal5gyASfHm92vjec7qtMuFgYx0nyJ8tq5+p6PV/YkwOAXOnmDQX2JSxlLeC yLgkQouLf1LJn+6yRMW6EXP61+m70vavaH0w+E4ILjbPitdED94oxjE5ocdyVayKWb goRhzuW5w3cnLAQHxpkkZo1LbUBK8EHquktM6hYwAV6ugKl6HvOalPjrwggLpasQVC +/c8H5D8fthgWNTj7gyxt054dCxD1Z0LWrwtyGxnsX0NqFxPl5rzfwTsGqtreUDEEP Y9nbKb8nzkCt1EOJd3IG6E6LnLttRlwsDG+XqPX8vswqQoNYVAiE0SYqnQ+YWhmvLI GQYQvM+PanZWw== Received: from work.stormshield.eu ([127.0.0.1]) by localhost (work.stormshield.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uhbnGNE4K8Sa; Mon, 31 May 2021 12:01:14 +0200 (CEST) Received: from work.stormshield.eu (localhost.localdomain [127.0.0.1]) by work.stormshield.eu (Postfix) with ESMTP id C87AB3760255; Mon, 31 May 2021 12:01:14 +0200 (CEST) Date: Mon, 31 May 2021 12:01:14 +0200 (CEST) From: Arnaud YSMAL To: freebsd-hackers Cc: SNS FreeBSD Message-ID: <831173652.7576991.1622455274800.JavaMail.zimbra@stormshield.eu> Subject: LACP drops packets for 3s on marker xmit error List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thread-Index: 7DYtd7snoDb4PakdUZBwocP5Wl0ywA== Thread-Topic: LACP drops packets for 3s on marker xmit error X-Rspamd-Queue-Id: 4FtrRJ1zNgz4WSB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=stormshield.eu header.s=BBC9ECEA-016A-11EA-9CC1-8A393C11FBBB header.b=dGihcyal; dmarc=none; spf=pass (mx1.freebsd.org: domain of arnaud.ysmal@stormshield.eu designates 91.212.116.1 as permitted sender) smtp.mailfrom=arnaud.ysmal@stormshield.eu X-Spamd-Result: default: False [-3.50 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[91.212.116.1:from]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(-0.20)[stormshield.eu:s=BBC9ECEA-016A-11EA-9CC1-8A393C11FBBB]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:91.212.116.1]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[stormshield.eu]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[91.212.116.1:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[stormshield.eu:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:49068, ipnet:91.212.116.0/24, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers] X-ThisMailContainsUnwantedMimeParts: N Hi, When a marker message could not be sent, the error is discarded and the lacp keep dropping transmit packets until the timeout is reached. A patch is available for review [1], it fixes this issue by clearing the flag when the lacp_xmit_marker function returns an error [2]. Could you please check it out? [1] https://reviews.freebsd.org/D30467 [2] https://github.com/freebsd/freebsd-src/blob/main/sys/net/ieee8023ad_lacp.c#L919 Best regards, Arnaud Ysmal R&D SNS - Software Engineer Stormshield 2/6 Parc de l'Horizon - 59650 Villeneuve d'Ascq - FR