From owner-freebsd-current@freebsd.org Mon Dec 14 14:03:31 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 384544BAB45 for ; Mon, 14 Dec 2020 14:03:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cvjm31CF8z4tmh; Mon, 14 Dec 2020 14:03:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 227BF1789; Mon, 14 Dec 2020 14:03:31 +0000 (UTC) From: Jan Beich To: Toomas Soome Cc: FreeBSD Current Subject: Re: review request: loader: implement framebuffer console References: Date: Mon, 14 Dec 2020 15:03:28 +0100 In-Reply-To: (Jan Beich's message of "Mon, 14 Dec 2020 14:39:42 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1607954611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n3THphCaHGCMkPrjcJnckNJu23xamnqgtuW6L8Ds+nk=; b=R0fp86AoZgKhzIlgOG6cP8iw1fEAeG5WpS7xuN0hYs48Y2X3QgjwD8Jfrfm7g/QTjhepx1 dvhQoD/VHXBUunme+JMZBw5J0PMAvNPje9sGoJQYgOVtgf0f9PDJ++7p+twjDh9rH8MnYB EBym4vdo3a1w04e93zhGw3pR9/MhdIJz+S5E7X5ZEDEH8CezKM6SqwTDiKWDiMfidFLxSt oyYl9Zi9QQstIe8eholZmhFnqpb4115KXCRJOFg+Lq3WewUFtStWJHvob7RvWRzGhirMBm dwdC39dndj13rN00W1fw2BjE6x0y7R5KPdsEz8ESKri3eIQ4IhSI31Sak4qwew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1607954611; a=rsa-sha256; cv=none; b=btiv+CgjzD60u1NUWv2BfrIeqfSWSC2xtowiwaWRVaBaD9TK+w1u/2VtbBnG4x72bXzEt9 4eQz06W//lFcht8tfFGgE2HCBG97CUdZRMZ+tjjFakvX9O06PSFZLr+UwVLBK1hKZijvdA cEQVXijCGNFEel3Rjznochn+EhkE5FbwG1r62EaFDH//0SDINYUEFevjXTK7/2TUuVLJsm XF36Sglq2qMRlyyDPTjQC+2TtFDWNsfu4LF2Nzkz1A7eUPRyHR/oSRePttTu17GnLJhUf8 yja21jPLXj158UdwEgfoZBfuhbNFzohVI+ufrfjNui41UM3IBJW9dU/RRO2wIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 14:03:31 -0000 Jan Beich writes: > Toomas Soome writes: > >> hi! >> >> I have been working on proper framebuffer support on FreeBSD loader >> and there is the current state: https://reviews.freebsd.org/D27420 >> >> >> All feedback is welcome, and especially if you can spare some time for testing:) > > Do you have another source? Phabricator excludes some files e.g., > > $ fetch 'https://reviews.freebsd.org/D27420?download=true' | patch -Efsp0 > $ make -sj8 buildworld > [...] > ===> stand/images (all) > make[4]: make[4]: don't know how to make freebsd-brand-rev.png. Stop FWIW, I've tried CLI but no joy: $ svn status $ pkg install arcanist-php80 $ arc patch D27420 PHP Deprecated: Function libxml_disable_entity_loader() is deprecated in /usr/local/lib/php/arcanist/support/init/init-script.php on line 92 Deprecated: Function libxml_disable_entity_loader() is deprecated in /usr/local/lib/php/arcanist/support/init/init-script.php on line 92 [2020-12-14 13:42:12] EXCEPTION: (Exception) Error while loading file "/usr/local/lib/php/arcanist/src/workflow/ArcanistWorkflow.php": Private methods cannot be final as they are never overridden by other classes at [/src/init/lib/PhutilBootloader.php:275] arcanist() #0 PhutilBootloader::executeInclude(string) called at [/src/init/lib/PhutilBootloader.php:207] #1 PhutilBootloader::loadLibrarySource(string, string) called at [/src/symbols/PhutilSymbolLoader.php:422] #2 PhutilSymbolLoader::loadSymbol(array) called at [/src/symbols/PhutilSymbolLoader.php:277] #3 PhutilSymbolLoader::selectAndLoadSymbols() called at [/src/init/init-library.php:23] #4 __phutil_autoload(string) #5 class_exists(string) called at [/src/symbols/PhutilClassMapQuery.php:216] #6 PhutilClassMapQuery::loadMap() called at [/src/symbols/PhutilClassMapQuery.php:184] #7 PhutilClassMapQuery::execute() called at [/src/runtime/ArcanistRuntime.php:535] #8 ArcanistRuntime::newWorkflows(ArcanistArcToolset) called at [/src/runtime/ArcanistRuntime.php:115] #9 ArcanistRuntime::executeCore(array) called at [/src/runtime/ArcanistRuntime.php:37] #10 ArcanistRuntime::execute(array) called at [/support/init/init-arcanist.php:6] #11 require_once(string) called at [/bin/arc:10] $ svn status $ pkg install arcanist-php74 $ arc patch D27420 [...] A (bin) stand/images/freebsd-logo-rev.png A (bin) stand/images/freebsd-brand.png A (bin) stand/images/freebsd-brand-rev.png A stand/images/Makefile svn: warning: W150002: 'stand/images' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation A stand/i386/libi386/vbe.h A stand/i386/libi386/vbe.c A stand/fonts/Makefile A stand/fonts/INDEX.fonts svn: warning: W150002: 'stand/fonts' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation A stand/common/gfx_fb.h A stand/common/gfx_fb.c A contrib/terminus/ter-u32n.bdf A contrib/terminus/ter-u32b.bdf A contrib/terminus/ter-u28n.bdf A contrib/terminus/ter-u28b.bdf A contrib/terminus/ter-u24n.bdf A contrib/terminus/ter-u24b.bdf A contrib/terminus/ter-u22n.bdf A contrib/terminus/ter-u22b.bdf A contrib/terminus/ter-u20n.bdf A contrib/terminus/ter-u20b.bdf A contrib/terminus/ter-u18n.bdf A contrib/terminus/ter-u18b.bdf A contrib/terminus/ter-u16v.bdf A contrib/terminus/ter-u16n.bdf A contrib/terminus/ter-u16b.bdf A contrib/terminus/ter-u14v.bdf A contrib/terminus/ter-u14n.bdf A contrib/terminus/ter-u14b.bdf A contrib/terminus/ter-u12n.bdf A contrib/terminus/ter-u12b.bdf svn: warning: W150002: 'contrib/terminus' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation A contrib/pnglite/pnglite.h A contrib/pnglite/pnglite.c A contrib/pnglite/README.md A contrib/pnglite/LICENSE svn: warning: W150002: 'contrib/pnglite' is already under version control svn: E200009: Could not add all targets because some targets are already versioned svn: E200009: Illegal target for the requested operation svn: E125004: MIME type 'application/octet-stream \ No newline at end of property' contains invalid character ' ' in media type svn: E125004: MIME type 'application/octet-stream \ No newline at end of property' contains invalid character ' ' in media type svn: E125004: MIME type 'application/octet-stream \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/images/Makefile' property 'svn:keywords' set on 'stand/images/Makefile' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/i386/libi386/vbe.h' property 'svn:keywords' set on 'stand/i386/libi386/vbe.h' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/i386/libi386/vbe.c' property 'svn:keywords' set on 'stand/i386/libi386/vbe.c' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/fonts/Makefile' property 'svn:keywords' set on 'stand/fonts/Makefile' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/common/gfx_fb.h' property 'svn:keywords' set on 'stand/common/gfx_fb.h' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'stand/common/gfx_fb.c' property 'svn:keywords' set on 'stand/common/gfx_fb.c' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'contrib/pnglite/pnglite.h' property 'svn:keywords' set on 'contrib/pnglite/pnglite.h' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type svn: E135001: Unrecognized line ending style 'native \ No newline at end of property' for 'contrib/pnglite/pnglite.c' property 'svn:keywords' set on 'contrib/pnglite/pnglite.c' svn: E125004: MIME type 'text/plain \ No newline at end of property' contains invalid character ' ' in media type OKAY Successfully applied patch to the working copy. $ ls -l stand/images/*.png -rw-r--r-- 1 foo foo 0 14 Dec 13:46 stand/images/freebsd-brand-rev.png -rw-r--r-- 1 foo foo 0 14 Dec 13:46 stand/images/freebsd-brand.png -rw-r--r-- 1 foo foo 0 14 Dec 13:46 stand/images/freebsd-logo-rev.png