From owner-svn-src-all@freebsd.org Tue Dec 4 08:52:51 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A67BE1329F51; Tue, 4 Dec 2018 08:52:51 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1E6AC6DEAF; Tue, 4 Dec 2018 08:52:51 +0000 (UTC) (envelope-from yuripv@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DE81113B4; Tue, 4 Dec 2018 03:52:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 04 Dec 2018 03:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/M3t95 nByqT/lP/gbI3vxjKBgFgpc7/O/sLHM66pfok=; b=jVOxqKXPaKrqtQVjebpmEG FngF/qxf6HGXJHObI6QB/HZ0T8F5O5vCrckBy7py2/RKnWkNnfzqvUdqK3LRb2SE ECRGE3khF7qtB44OGSpnvQI7IwNsr0MloXompgGjRJd91SWLZUT/ppBDxoxB6Xu+ gWKrDLPj73wo4y2eYyZdM7ENvBHbPdDnNE8VZjdRGMqnGfsk+luZiEduf86Zavsg rBgaPv/VCogA12OJxiBUYw+2OuGUDrfPz8eWjIWzKV+FqQEj+t//YQmIjeFq4wa5 SVqhEYRgm+R2Gcl5ch11XmMRBp0v+82YWUdYS/f827WUE47QSOnALJjdQzDIow9g == X-ME-Sender: X-ME-Proxy: Received: from [192.168.1.2] (unknown [62.183.125.176]) by mail.messagingengine.com (Postfix) with ESMTPA id A8DF410314; Tue, 4 Dec 2018 03:52:41 -0500 (EST) Subject: Re: svn commit: r341446 - head/release/amd64 To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <20181204084122.GB94570@FreeBSD.org> From: Yuri Pankov Openpgp: preference=signencrypt Autocrypt: addr=yuripv@FreeBSD.org; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNH1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD7CwJcEEwEIAEECGwMFCQWjmoAF CwkIBwMFFQoJCAsFFgMCAQACHgECF4AWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW708wAIZ AQAKCRCTi+B/sSrhbPxBB/961alcU091O+yKT5/oReHVc/PX0Tz4sW3V44AcgLfYlrZavCro EFz90qmCrl0xqEwuAKcC4bjmL8SjPWAhSN6IH9nxdw+HeZnAPiHm/q679Bu47+nHBl3qD/9p +t1PkKeKZfaWToFMt1nq06ytSu6VLMCwLdlDNe6DReX0ex/afEqKsuaIZSKL4UYjRwklp8PU Uf98QkrfapyHB67hQMzfI4tPeJaYyv0cTgfq3kUWJx1V6Xi0b6Zxj4ZrB2TXvaMO5g7yhU9E E3WWAvoe4FgB3a7dHe8atnHhq5+Cuvm6+LD4Jh7jvMAE5UMN+xxQpnGpNghHjaCy4vXrLRBZ nhRYzsBNBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFSc XACDsdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIol Dahy2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CA NN8F1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC 0sE2Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4z ABEBAAHCwHwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAK CRCTi+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuU D3kh2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy +jsnTfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6 Kv+VRu54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2v ZHBB6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> Date: Tue, 4 Dec 2018 11:52:34 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20181204084122.GB94570@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d6NLY095uvyd1s3pJMlq9wjdBFtITahdK" X-Rspamd-Queue-Id: 1E6AC6DEAF X-Spamd-Result: default: False [-0.56 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.44)[-0.443,0]; NEURAL_SPAM_LONG(0.20)[0.198,0]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; NEURAL_HAM_SHORT(-0.32)[-0.319,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 08:52:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK Content-Type: multipart/mixed; boundary="vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd"; protected-headers="v1" From: Yuri Pankov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> Subject: Re: svn commit: r341446 - head/release/amd64 References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <20181204084122.GB94570@FreeBSD.org> In-Reply-To: <20181204084122.GB94570@FreeBSD.org> --vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Alexey Dokuchaev wrote: > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote: >> New Revision: 341446 >> URL: https://svnweb.freebsd.org/changeset/base/341446 >> >> Log: >> mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs= =2E >> =20 >> This fixes 'cdrom' target in the case when world was built by user, >> and not root. >=20 > Could you please explain why -p should not have been used here? I fail= > to understand this from the commit log. I've always considered preserv= ing > various file metadata as a good thing to do, and this commit puzzles me= =2E Because the target is on msdosfs, and the only metadata that can be preserved is modification time which isn't that useful with the file being hidden in ESP. OTOH, 'cp -p' fails trying to preserve owner/group if source is not owned by root (as commit message says). Additional 'chmod' call done in HBSD doesn't do much as well -- it seems we can only set/unset owner's 'write' flag which corresponds to DOS 'readonly' attribute. --vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd-- --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwGQFIACgkQk4vgf7Eq 4WzZzAf3XCx2LCnKnnkp3y4o/ZeNKzQNBzokTiEEBRwK91rsAYpV4CpYv/0GtJAX xlK/vVgoIhnWc5F34ESdQSk2iek1LflVc+/Snnn7ZMx2oPyBz09fml7VgvxHOPiY LF9NCvA+HnpvAP7CLvydxGvdqQuUy3EGA2M2Z23dXY+1h9MqnxxZY0B/2dnNiDoB E7kyNGVsnQAED98ufOJvXBSzeRln3/KsTB8w7h3KSfiP+6LbJL7gqEQfKqGu13Qg pm6JJiJX1oOiNRh6VODeUp6sNrShEmVdBp/GVlNDg8krsGvSdEgExGQLfPIr0JqI REGZ857GxYfEExvYZCucqCJRFNAW =Bxkd -----END PGP SIGNATURE----- --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK--