Date: Tue, 4 Dec 2018 11:52:34 +0300 From: Yuri Pankov <yuripv@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341446 - head/release/amd64 Message-ID: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> In-Reply-To: <20181204084122.GB94570@FreeBSD.org> References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <20181204084122.GB94570@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK Content-Type: multipart/mixed; boundary="vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd"; protected-headers="v1" From: Yuri Pankov <yuripv@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> Subject: Re: svn commit: r341446 - head/release/amd64 References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <20181204084122.GB94570@FreeBSD.org> In-Reply-To: <20181204084122.GB94570@FreeBSD.org> --vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Alexey Dokuchaev wrote: > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote: >> New Revision: 341446 >> URL: https://svnweb.freebsd.org/changeset/base/341446 >> >> Log: >> mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs= =2E >> =20 >> This fixes 'cdrom' target in the case when world was built by user, >> and not root. >=20 > Could you please explain why -p should not have been used here? I fail= > to understand this from the commit log. I've always considered preserv= ing > various file metadata as a good thing to do, and this commit puzzles me= =2E Because the target is on msdosfs, and the only metadata that can be preserved is modification time which isn't that useful with the file being hidden in ESP. OTOH, 'cp -p' fails trying to preserve owner/group if source is not owned by root (as commit message says). Additional 'chmod' call done in HBSD doesn't do much as well -- it seems we can only set/unset owner's 'write' flag which corresponds to DOS 'readonly' attribute. --vCshcU24NcBVZUOtjfnm9eo0IEpmMkVgd-- --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwGQFIACgkQk4vgf7Eq 4WzZzAf3XCx2LCnKnnkp3y4o/ZeNKzQNBzokTiEEBRwK91rsAYpV4CpYv/0GtJAX xlK/vVgoIhnWc5F34ESdQSk2iek1LflVc+/Snnn7ZMx2oPyBz09fml7VgvxHOPiY LF9NCvA+HnpvAP7CLvydxGvdqQuUy3EGA2M2Z23dXY+1h9MqnxxZY0B/2dnNiDoB E7kyNGVsnQAED98ufOJvXBSzeRln3/KsTB8w7h3KSfiP+6LbJL7gqEQfKqGu13Qg pm6JJiJX1oOiNRh6VODeUp6sNrShEmVdBp/GVlNDg8krsGvSdEgExGQLfPIr0JqI REGZ857GxYfEExvYZCucqCJRFNAW =Bxkd -----END PGP SIGNATURE----- --d6NLY095uvyd1s3pJMlq9wjdBFtITahdK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05039715-2792-fdb2-735f-c5842f4d8087>