From owner-freebsd-bugs@FreeBSD.ORG  Mon Feb 23 09:30:06 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 96E0116A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 23 Feb 2004 09:30:06 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8580943D1F
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 23 Feb 2004 09:30:06 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i1NHU6bv019749	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 23 Feb 2004 09:30:06 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1NHU6hH019734;
	Mon, 23 Feb 2004 09:30:06 -0800 (PST)
	(envelope-from gnats)
Date: Mon, 23 Feb 2004 09:30:06 -0800 (PST)
Message-Id: <200402231730.i1NHU6hH019734@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Brian Candler <B.Candler@pobox.com>
Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch]
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Brian Candler <B.Candler@pobox.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 17:30:06 -0000

The following reply was made to PR kern/63171; it has been noted by GNATS.

From: Brian Candler <B.Candler@pobox.com>
To: John Baldwin <john@baldwin.cx>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch]
Date: Mon, 23 Feb 2004 17:21:23 +0000

 On Mon, Feb 23, 2004 at 10:34:08AM -0500, John Baldwin wrote:
 > The pointer fix does not seem correct.  usbd_set_polling() does take a 
 > usbd_device_handle, not an interface pointer, so the existing code is correct 
 > on -current at least.  Note that on 4.x, the poll method in ukbd.c does not 
 > use usbd_device_handle's but does pass the iface pointer in.  This is due to 
 > the usbd code being different in current and stable.
 
 Ah, this is probably because I updated ukbd.c to a newer version in an
 attempt to see if the problem had already been fixed.
 
 Until I changed it, gcc was giving an "incompatible pointer type" warning in
 two places when ukbd.c was compiled.
 
 In my usbdi.c [1.60] I have:
 
 usbd_set_polling(usbd_interface_handle iface, int on)
 
 But I see that the CVS head [1.84] has usbd_device_handle instead. So you're
 quite right, and sorry for the noise.
 
 > I have committed the ukbd rollover fix however.
 
 Thank you!
 
 Brian.