From owner-freebsd-stable@freebsd.org Mon Dec 14 16:59:30 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E672A43B2A for ; Mon, 14 Dec 2015 16:59:30 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E5AF15D3; Mon, 14 Dec 2015 16:59:30 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by wmnn186 with SMTP id n186so129514414wmn.0; Mon, 14 Dec 2015 08:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=tWNDbGYAncYT0wh9+801TYB+x6l8r7dubjV8+XBqzek=; b=T6Wl++0Sz2xFpB9/tOC35z9naytDMqM7p+NYb92DBP7blmOegbgGa94p391fAMgE5x 0rWrsYZhJ4u6SPy8YYVjhb43llkq5UwBlXcNrV7VKiC2AcvhWmHK2h/LeK2VE9SfPjmo 2Gf/0QFLej3OxtdIMxNnGReTkCYx4//S+2/NmNkzzzZio9au9sActhe6f06yRw/B8HeX jmgZP9BN2MGbKBvYasMoxpzNg/M2LtEY0xpQJwouiRUPo9d4P7VXKCKRm/V6OqV3E/q+ augGtxVLEhVVEpvqa1BTlEKGyoBvQKitZ/qbDUNjYVkj4f8kjFcwZLerT/wnaSEXTAJw 4uRA== X-Received: by 10.28.186.67 with SMTP id k64mr26691523wmf.56.1450112341759; Mon, 14 Dec 2015 08:59:01 -0800 (PST) Received: from jarvis.whl (58.wheelsystems.com. [83.12.187.58]) by smtp.gmail.com with ESMTPSA id bh6sm30669561wjb.0.2015.12.14.08.59.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Dec 2015 08:59:00 -0800 (PST) Sender: Mariusz Zaborski Date: Mon, 14 Dec 2015 17:58:58 +0100 From: Mariusz Zaborski To: "Andrey V. Elsukov" Cc: NGie Cooper , FreeBSD-Stable ML Subject: Re: make tinderbox broken with LINT-NOINET on ref10-amd64.freebsd.org (if_gif compilation issues) Message-ID: <20151214165858.GA76268@jarvis.whl> References: <20151214165111.GA70582@jarvis.whl> <566EF46A.8080704@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566EF46A.8080704@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 16:59:30 -0000 On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote: > On 14.12.15 19:51, Mariusz Zaborski wrote: > > On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote: > >> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on > >> amd64/i386 with if_gif(4) on stable/10. Could you please fix this? > >> Thanks, -NGie > > Hi, > > > > I already found the problem we need to MFC r276224 and r277130. > > I don't think r277130 is related to this problem. > I have this patch and I'm trying to build with them. Not with this but after fixing r276224 it will crash in other place which r277130 is fixing. :) > > -- > WBR, Andrey V. Elsukov > Index: stable/10/sys/modules/if_gif/Makefile > =================================================================== > --- stable/10/sys/modules/if_gif/Makefile (revision 292213) > +++ stable/10/sys/modules/if_gif/Makefile (working copy) > @@ -5,7 +5,7 @@ > .PATH: ${.CURDIR}/../../net ${.CURDIR}/../../netinet ${.CURDIR}/../../netinet6 > > KMOD= if_gif > -SRCS= if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h > +SRCS= if_gif.c opt_inet.h opt_inet6.h opt_mrouting.h > > .if !defined(KERNBUILDDIR) > opt_inet.h: > @@ -15,10 +15,11 @@ opt_inet.h: > opt_inet6.h: > echo "#define INET6 1" > ${.TARGET} > .endif > - > -opt_mrouting.h: > - echo "#define MROUTING 1" > ${.TARGET} > .else > +OPT_INET!= cat ${KERNBUILDDIR}/opt_inet.h; echo > +.if empty(OPT_INET) > +MK_INET_SUPPORT=no > +.endif > OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h; echo > .if empty(OPT_INET6) > MK_INET6_SUPPORT= no > @@ -25,6 +26,10 @@ MK_INET6_SUPPORT= no > .endif > .endif > > +.if ${MK_INET_SUPPORT} != "no" > +SRCS+= in_gif.c > +.endif > + > .if ${MK_INET6_SUPPORT} != "no" > SRCS+= in6_gif.c > .endif -- Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD commiter | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1