Date: Tue, 13 Mar 2001 14:30:03 -0800 (PST) From: FUJISHIMA Satsuki <sf@FreeBSD.org> To: freebsd-ports@FreeBSD.org Subject: Re: ports/25670: Fix of x11/xmove by Maintainer. Message-ID: <200103132230.f2DMU3A95199@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/25670; it has been noted by GNATS. From: FUJISHIMA Satsuki <sf@FreeBSD.org> To: sobomax@FreeBSD.org Cc: sec@ice.42.org, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/25670: Fix of x11/xmove by Maintainer. Date: Wed, 14 Mar 2001 07:24:45 +0900 USE_IMAKE can't be used for this port as it does not have Imakefile. ===> Extracting for xmove-2.0b2 >> Checksum OK for xmove.2.0beta2.tar.gz. ===> xmove-2.0b2 depends on executable: imake - found ===> xmove-2.0b2 depends on shared library: X11.6 - found /bin/cp /tmp/xmove/files/Makefile /usr/obj/ports/tmp/xmove/work/xmove ===> Patching for xmove-2.0b2 ===> Applying FreeBSD patches for xmove-2.0b2 ===> Configuring for xmove-2.0b2 mv -f Makefile Makefile.bak imake -DUseInstalled -I/usr/X11R6/lib/X11/config imake: No such file or directory imake: No description file. Stop. *** Error code 1 Stop in /tmp/xmove. *** Error code 1 Stop in /tmp/xmove. *** Error code 1 Stop in /tmp/xmove. *** Error code 1 Stop in /tmp/xmove. ======== Proper fix is to use own Imakefile instead of Makefile. How about this patch? o copying files/Imakefile instead of Makefile to USE_IMAKE work. o makeing/installing html manpages. o replace magic number to macro in DISTNAME. o move post-extract to post-patch to get as-is distfile after make extract. -- FUJISHIMA Satsuki Index: Makefile =================================================================== RCS file: /home/ncvs/ports/x11/xmove/Makefile,v retrieving revision 1.7 diff -u -u -2 -r1.7 Makefile --- Makefile 2001/03/13 16:06:46 1.7 +++ Makefile 2001/03/13 22:15:55 @@ -10,5 +10,5 @@ CATEGORIES= x11 MASTER_SITES= ftp://ftp.cs.columbia.edu/pub/xmove/ -DISTNAME= ${PORTNAME}.2.0beta2 +DISTNAME= ${PORTNAME}.${PORTVERSION:S/b/beta/} MAINTAINER= sec@42.org @@ -21,11 +21,11 @@ MAN1= xmove.1 xmovectrl.1 -post-extract: - ${CP} ${FILESDIR}/Makefile ${WRKSRC} +WRKSRC= ${WRKDIR}/${PORTNAME} -post-install: -.for man in ${MAN1} - ${INSTALL_MAN} ${WRKSRC}/man/man1/${man} ${X11BASE}/man/man1 -.endfor +post-patch: + ${CP} ${FILESDIR}/Imakefile ${WRKSRC} + (cd ${WRKSRC}; \ + ${CP} man/man1/xmove.1 xmove/xmove.man; \ + ${CP} man/man1/xmovectrl.1 xmovectrl/xmovectrl.man) .include <bsd.port.mk> Index: files/Imakefile =================================================================== RCS file: Imakefile diff -N Imakefile --- /dev/null Wed Mar 14 07:19:14 2001 +++ Imakefile Tue Mar 13 22:00:44 2001 @@ -0,0 +1,6 @@ +#define IHaveSubdirs +#define PassCDebugFlags CDEBUGFLAGS="$(CDEBUGFLAGS)" + +SUBDIRS= xmove xmovectrl +MakeSubdirs($(SUBDIRS)) +DependSubdirs($(SUBDIRS)) Index: files/Makefile =================================================================== RCS file: Makefile diff -N Makefile --- /var/tmp/cvsKaz0LGhumR Wed Mar 14 07:20:41 2001 +++ /dev/null Wed Mar 14 07:19:14 2001 @@ -1,6 +0,0 @@ -all: - cd xmove;xmkmf && make - cd xmovectrl;xmkmf && make -install: - cd xmove;make install - cd xmovectrl;make install To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103132230.f2DMU3A95199>