From owner-freebsd-current Sun Feb 11 20:39: 9 2001 Delivered-To: freebsd-current@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id E22AF37B401 for ; Sun, 11 Feb 2001 20:39:04 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f1C4cvU45235; Sun, 11 Feb 2001 20:38:57 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200102120438.f1C4cvU45235@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Bruce Evans Cc: Matt Dillon , Tor.Egge@fast.no, eischen@vigrid.com, current@FreeBSD.ORG Subject: Re: HEADS UP: installworld gotchas In-Reply-To: Date: Sun, 11 Feb 2001 20:38:57 -0800 From: Peter Wemm Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Sun, 11 Feb 2001, Peter Wemm wrote: > > > I cant help but wonder why on earth we didn't have it like this from the > > start: > > > > Index: include/stdio.h > > =================================================================== > > RCS file: /home/ncvs/src/include/stdio.h,v > > retrieving revision 1.26 > > diff -u -r1.26 stdio.h > > --- include/stdio.h 2001/02/11 22:04:18 1.26 > > +++ include/stdio.h 2001/02/12 01:27:16 > > @@ -132,6 +132,9 @@ > > > > __BEGIN_DECLS > > extern FILE __sF[]; > > +extern FILE *__stdin; > > +extern FILE *__stdout; > > +extern FILE *__stderr; > > __END_DECLS > > Once upon a time, people counted every instruction in getchar(), etc., > and programmed it carefully to unnecessary indirections, not to mention > function calls and locks. And, because it breaks global declarations like this: FILE *buffer = stdout; /* default buffer file is stdout */ I have fixed this to avoid the indirection, and am doing a buildworld to check it. It should be the same speed as before, but is still immune to the FILE size changes. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message