From owner-dev-commits-src-all@freebsd.org Tue Apr 13 19:53:19 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE0A25EA325 for ; Tue, 13 Apr 2021 19:53:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FKbrH4NCtz3Jpx for ; Tue, 13 Apr 2021 19:53:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id d15so6167624qkc.9 for ; Tue, 13 Apr 2021 12:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+HvWLAX8L+JSwgY53akFzeehsKaEXff5iWNs2oQrWSs=; b=h207l1JNgDDEE8k7yGa1BLB3ZLBRcyqBIMiKZIeV4AhlDXRecEirCR5sTDKCqbTOwW 1AjT+hYG/4QI5NY6ZRBv1cf/LVf9XMI8jAmJnewg8YC26HnGY3AG/Se7AZytC/CXeQ8U PDXeWfDZjtBB6XcXE2SDlmsAbPCmlC78pFNCPfzdKDRC8qkHvndVeOx51vZ+EiiRo4cK U+WFihgz4EiqcPvfiaTseekRCAMGq8FxPF2Jwt1A2Fbjw6G/s3Zjhb2Pf56yDco8hKU2 mg1/jWURQigbgjtM/ToxYWXN2UMbu6Bgp/Agxx4hVFoEGZ1H1iuMS32YXeHIehdZJb6j IEnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+HvWLAX8L+JSwgY53akFzeehsKaEXff5iWNs2oQrWSs=; b=Oi5XpVAuLnLTE6N76BMjZJoeiEgwqx0WjHivsY82+I64ksttJwO99LiEyELyyk38fT GmBmXwIGpx99GhvdPNGSV48NZ71cctFwgvrjSNhlTelCL1SFHyTdE7cvf7JMpWs6kPHd sTaSzwcsXwKi/ygZuSlph/ALhiL1pxhu80+DTceCjhATPIwLedmU8m+W4rMjTrLzfTIy WRoIMZz3druU3cAIAl4KJYusEL77PA00HNmzwq7yBRJ/iBOVJXAvmcewJO9DboyFIN/2 wR6m2Mhy6OzB3GyUoMn2xQjQNP7oOvfGDQluzEn2C2Ft5LjXeLlJA2xwj+pPeM1v5/w3 9Pqg== X-Gm-Message-State: AOAM533WA+bfNAnmWKHOcFcRrE9cQz2+weQQ1jAdJkLip+8rgSYrbH0A JvkgHDKUJmRSM2H9pD6w7twUoUhBzhgKrmEaeB+a3g== X-Google-Smtp-Source: ABdhPJwT3buwJsD0zeIMTg3qg5OovbMrlNDgvcGyHdV0ayco/chuAmpPyd+wXggFmPDn/xq60ZeDM2QzvP6/ulz1t/g= X-Received: by 2002:ae9:ed07:: with SMTP id c7mr15179723qkg.89.1618343598579; Tue, 13 Apr 2021 12:53:18 -0700 (PDT) MIME-Version: 1.0 References: <202104131138.13DBcgrt085662@gitrepo.freebsd.org> <9e0d4574-bcad-b24c-78ad-c172d6d2c221@FreeBSD.org> In-Reply-To: <9e0d4574-bcad-b24c-78ad-c172d6d2c221@FreeBSD.org> From: Warner Losh Date: Tue, 13 Apr 2021 13:53:07 -0600 Message-ID: Subject: Re: git: 73c14cc76b5f - main - Remove history.immutable from .arcconfig To: John Baldwin Cc: Alex Richardson , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FKbrH4NCtz3Jpx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 19:53:19 -0000 On Tue, Apr 13, 2021 at 9:23 AM John Baldwin wrote: > On 4/13/21 4:38 AM, Alex Richardson wrote: > > The branch main has been updated by arichardson: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=73c14cc76b5f815c6b1bd93089ebafdd9269d343 > > > > commit 73c14cc76b5f815c6b1bd93089ebafdd9269d343 > > Author: Alex Richardson > > AuthorDate: 2021-04-13 11:36:24 +0000 > > Commit: Alex Richardson > > CommitDate: 2021-04-13 11:36:25 +0000 > > > > Remove history.immutable from .arcconfig > > > > The `history.immutable` setting prevents arcanist from updating > > the commit messages with the Differential URL and therefore > > makes updating patches awkward with a rebase workflow. > > > > In case this new behaviour is not wanted the old one can be restored > > by running `arc set-config --local history.immutable true`. > > > > Test Plan: `arc diff --create HEAD^` adds the metadata now. > > > > Reviewed By: #phabric-admin, imp, lwhsu > > Differential Revision: https://reviews.freebsd.org/D27971 > > FYI, this might break git arc since arc will now start rewriting commits > rather than leaving them alone. If so, we can look use 'arc diff' > with --head to turn off some of its magic. It would also avoid having > 'git arc' have to adjust the working copy. > I'd honestly rather have 'git arc create' stamp this in from the git go. I really dislike having it not there until just before I go to commit. Warner