From owner-freebsd-hackers  Sat Feb  3 16: 0:41 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP
	id E335637B69D; Sat,  3 Feb 2001 16:00:16 -0800 (PST)
Received: by bazooka.unixfreak.org (Postfix, from userid 1000)
	id 95DEE3E02; Sat,  3 Feb 2001 16:00:16 -0800 (PST)
Received: from unixfreak.org (localhost [127.0.0.1])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id 8EDF93C10B; Sat,  3 Feb 2001 16:00:16 -0800 (PST)
To: Matt Dillon <dillon@earth.backplane.com>
Cc: mi@aldan.algebra.com, deischen@FreeBSD.ORG, hackers@FreeBSD.ORG
Subject: Re: mount_md (was: mdconfig config file (was: cvs commit: src/sys/i386/conf GENERIC)) 
In-Reply-To: Message from Matt Dillon <dillon@earth.backplane.com> 
   of "Sat, 03 Feb 2001 11:36:04 PST." <200102031936.f13Ja4G11258@earth.backplane.com> 
Date: Sat, 03 Feb 2001 16:00:11 -0800
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010204000016.95DEE3E02@bazooka.unixfreak.org>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> 
> :Some thoughts:
> :
> :  - If you want softupdates, you need to specify the -S flag.  Should
> :    softupdates be the default?
> 
>     That's a hard one.  Considering that people who have mfs in their fstab
>     probably expect as little disk I/O as possible, softupdate sshould
>     probably be enabled by default.

Okay.  Now the -S flag is used to disable softupdates.  You can find
the updated code at the same place (for your convenience, it is:
http://www.unixfreak.org/~dima/home/mount_md.c).

Also, the only reason mount_md runs tunefs is to enable softupdates.
Perhaps it would be benificial to enable it during the newfs run?
This would save one fork/exec sequence; I don't know whether it's
worth it.  I wrote a small patch to newfs to add a -g flag which will
enable softupdates; you can find the diff at
http://www.unixfreak.org/~dima/home/newfs-softdep.diff.  It seems like
it might be a good convenience feature (for manual newfs use and
otherwise).

> 
> :  - To suppress the output of disklabel/newfs/etc., it closes fds 0-2.  Is
> :    this evil?  Should I devise another method of doing this (something
> :    like opening /dev/null and dup2'ing that fd to 0-2)?
> 
>     Yes, that is evil.  opening and dup2()ing /dev/null to 0, 1, and 2
>     is the prefered method.

Fixed.

> 
> :  - Should there be an option to make use of md's autounit feature?  I
> :    don't think it will be very hard to implement, but I don't know how
> :    useful it would be.
> 
>     Yes, I think this should be the default.

Also fixed.  It now accepts '/dev/md' or 'md' as the md-device
parameter (the first after the arguments) to mean 'use autounit'.

Regards

					Dima Dorfman
					dima@unixfreak.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message